Issue metadata
Sign in to add a comment
|
Web push permission prompt not translated |
||||||||||||||||||||||||
Issue descriptionRunning current canary: 67.0.3396.3 Android version: 8.1.0 Pixel 2 XL See screenshot (Android language settings are set to Spanish). I would expect the "Wants to send notifications" text to be in Spanish.
,
Apr 18 2018
,
Apr 18 2018
Tested the issue using #67.0.3396.3 on 8.1.0 Pixel 2 XL and could reproduce the issue as per the steps mentioned below. Steps: 1. Launched Browser 2. Changed to Phone language to Spanish 3. Navigated to www.gamespot.com 4. Observed Permission bubble text is seen in English Note: 1. Location permission bubble is seen in Spanish on navigating to Baidu.com 2. Untriaging for further inputs on this issue. Thanks!!
,
Apr 20 2018
Hi, This window is for chromium bug reporting. I can see that this is not a chromium bug issue. It is more on a website localization issue. Please confirm. Regards!
,
Apr 20 2018
The website does not control the language of control of that prompt. That's a browser prompt for permission, and should be localized by the browser.
,
Apr 20 2018
,
Apr 20 2018
Per #5, add back localization component label
,
Apr 20 2018
Also bump up priority since it is impacting the comping stable.
,
Apr 23 2018
,
Apr 30 2018
Hi, This window is for chromium bug reporting. UI>Browser has been added, please do not add UI>Localization on this bug. to zea@chromium.org/jialiul@chromium.org, you can file a bug through buganizer tool. Regards!
,
Apr 30 2018
Re #10 I'm confused by your comment. Why is UI>Localization not appropriate here? The text in question is not localized properly.
,
May 1 2018
For reference, I think this is IDS_NOTIFICATIONS_INFOBAR_TEXT, with translation ID 5426179911063097041. It is definitely a translation issue in Chromium. Please leave the UI>Localization component per the Translation Issue template until we triage this otherwise. Looking at current source, there does appear to be a translation for that string: <translation id="5426179911063097041"><ph name="SITE" /> quiere enviarte notificaciones</translation> Is it possible that a build was missing some portions of the generated GRD file for Spanish? Can we reproduce this or a newer Canary?
,
May 1 2018
Testing this in M68 Canary on Android 8.1.0 the correct Spanish translation appears. Additionally, the correct translation appears on M66 Stable on Android 8.1.0 for me. Maybe this was an isolated build of M67 that had an incorrectly generated Spanish GRD file? sandeepkumars@ Were you able to reproduce this in M68? Have we tested it in different builds of M67?
,
May 2 2018
Today I was able to test this on Android Chrome Dev 67.0.3396.29 and was unable to reproduce, which makes it seem more likely that this was a build issue. Looking at https://chromium.googlesource.com/chromium/src/+/c2d73c6324eb2309513d140d9dd2d2de2ea9e8e7%5E%21/#F177 (the diff for generated_resources_es.xtb for the 67.0.3396.29 release), it looks like the translated string was added back in, but had previously been missing. Closing this as Fixed since I think it's just a transient build error, but feel free to re-open if the problem is broader. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jialiul@chromium.org
, Apr 17 2018Components: -UI>Browser>Permissions>Prompts UI>Localization