Issue metadata
Sign in to add a comment
|
[MacViews-Browser] Regression: Sub Folder in Bookmarks Bar Folder is not visible in Incognito Mode |
||||||||||||||||||||||
Issue descriptionChrome Version:Canary 68.0.3398.0 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Enable MacViews-Browser (2) Open an Incognito Window (3) Click on a BMB Folder, so that the Menu appears (4) Add a sub folder into that folder What is the expected result? To see the Sub folder. What happens instead? The sub folder is very hard to see. Screenshots are attached. This is a regression from https://chromium-review.googlesource.com/1012966 lgrey@: Can you please take a look? Thanks :-) Mehmet
,
Apr 25 2018
Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
,
May 24 2018
,
Jun 20 2018
,
Jun 22 2018
,
Jul 2
,
Jul 12
,
Jul 12
,
Jul 26
,
Jul 30
Issue 868825 has been merged into this issue.
,
Jul 30
Looked into this a little before I realized it was a dupe. We're using the parent widget to set the folder color https://cs.chromium.org/chromium/src/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc but not the text color. This works on non-Mac platforms because it seems like we make the top chrome much darker on Mac in incognito? (Not sure on Windows, but on Linux incognito just looks greyer to me) A worse-is-better fix might be to just ifdef that line to ignore the theme on Mac, especially since issue 829891 which prompted this code isn't an issue on Mac (we use the system icons so the only choices are light and dark).
,
Jul 31
Supporting dark mode in menus will make this better, but won't make M69.
,
Aug 20
mac triage: -> lgrey@
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6e5208337d8981500ff24bd25e7eb6c7926e5bc commit a6e5208337d8981500ff24bd25e7eb6c7926e5bc Author: Leonard Grey <lgrey@chromium.org> Date: Tue Aug 28 20:47:48 2018 MacViews: use dark on light icon in incognito bookmark folders Bug: 833973 Change-Id: I12adaf55546312ab6f348abca0671358eec5757d Reviewed-on: https://chromium-review.googlesource.com/1194463 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#586842} [modify] https://crrev.com/a6e5208337d8981500ff24bd25e7eb6c7926e5bc/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
,
Aug 30
Able to reproduce the issue on Mac 10.13.3 using chrome reported version #68.0.3398.0 Tested the fix on Mac 10.13.3 using latest chrome version #70.0.3537.0 as per the comment #0. Attaching screen cast and screen shot for reference. Observed that on creating a folder at BMB, doesn't render properly in incognito mode (an issue) but the sub folder in Bookmarks Bar Folder is visible in Incognito Mode. lgrey@ - Could you please check the attached screen cast and screenshot and help us in confirming the fix. Thanks...!!
,
Aug 30
The above seems like a separate issue with bookmark button height when no button is showing (for example, do the same thing, but instead of creating a folder, bookmark a page). I'll file a separate issue for that.
,
Aug 30
Filed as Issue 879154
,
Sep 14
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Apr 17 2018Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)