New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833967 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Some string changes for Keyboard Shortcut Viewer

Project Member Reported by wutao@chromium.org, Apr 17 2018

Issue description

Create this issue for merge request for string changes for Keyboard Shortcut Viewer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef0c06493679b4eb213586ac8bed8d481a53791a

commit ef0c06493679b4eb213586ac8bed8d481a53791a
Author: wutao <wutao@chromium.org>
Date: Tue Apr 17 21:26:24 2018

cros: String changes for Shortcuts Viewer

This cl makes some string changes for Keyboard Shortcuts Viewer based on
TC.

Bug:  833967 , b/77166809, b/77861902
Test: manual
Change-Id: Ib28c40c1aea1303151bf2f4a687df7f230760cfa
Reviewed-on: https://chromium-review.googlesource.com/1015601
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551480}
[modify] https://crrev.com/ef0c06493679b4eb213586ac8bed8d481a53791a/ash/components/shortcut_viewer_strings.grdp

Comment 2 by wutao@chromium.org, Apr 17 2018

Labels: Merge-Request-67
Labels: -Merge-Request-67 Merge-Approved-67
Approving merge to M67 Chrome OS.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed2c06e8894e6e2380f5a328f549a7170c38b811

commit ed2c06e8894e6e2380f5a328f549a7170c38b811
Author: wutao <wutao@chromium.org>
Date: Wed Apr 18 18:43:51 2018

M67 merge: cros: String changes for Shortcuts Viewer

This cl makes some string changes for Keyboard Shortcuts Viewer based on TC.

TBR=warx@google.com

Bug:  833967 , b/77166809, b/77861902
Test: manual
Change-Id: Ib28c40c1aea1303151bf2f4a687df7f230760cfa
Reviewed-on: https://chromium-review.googlesource.com/1015601
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551480}(cherry picked from commit ef0c06493679b4eb213586ac8bed8d481a53791a)
Reviewed-on: https://chromium-review.googlesource.com/1016864
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#87}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/ed2c06e8894e6e2380f5a328f549a7170c38b811/ash/components/shortcut_viewer_strings.grdp

Comment 5 by wutao@chromium.org, Apr 18 2018

Status: Fixed (was: Available)

Comment 6 by wutao@chromium.org, Apr 19 2018

Status: Available (was: Fixed)
Change one more string: b/77926752
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58898a0ff1fa4222b6cebc3100d16e893c2388c7

commit 58898a0ff1fa4222b6cebc3100d16e893c2388c7
Author: wutao <wutao@chromium.org>
Date: Thu Apr 19 00:35:31 2018

cros: Change one string for Shortcuts Viewer

This cl changes one string for Keyboard Shortcuts Viewer based on TC.

Bug:  833967 , b/77926752
Test: manual
Change-Id: Ibb0dd9994acaa07f4a9e005a20f837cae2d8a150
Reviewed-on: https://chromium-review.googlesource.com/1018340
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551898}
[modify] https://crrev.com/58898a0ff1fa4222b6cebc3100d16e893c2388c7/ash/components/shortcut_viewer_strings.grdp

Comment 8 by wutao@chromium.org, Apr 19 2018

Cc: kbleicher@chromium.org
+kbleicher@, request to merge cl on #7. Thanks!

Comment 9 by wutao@chromium.org, Apr 24 2018

Hi kbleicher@, the cl in #7 has one more string change. Would you please take a look. Thanks.
Approving merge to M67 Chrome OS.

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80fb126eaace00f6e099ed10d9920da7c17365b3

commit 80fb126eaace00f6e099ed10d9920da7c17365b3
Author: wutao <wutao@chromium.org>
Date: Tue Apr 24 21:53:08 2018

M67 merge: cros: Change one string for Shortcuts Viewer

This cl changes one string for Keyboard Shortcuts Viewer based on TC.

TBR=warx@chromium.org

Bug:  833967 , b/77926752
Test: manual
Change-Id: Ibb0dd9994acaa07f4a9e005a20f837cae2d8a150
Reviewed-on: https://chromium-review.googlesource.com/1018340
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551898}(cherry picked from commit 58898a0ff1fa4222b6cebc3100d16e893c2388c7)
Reviewed-on: https://chromium-review.googlesource.com/1026810
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#268}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/80fb126eaace00f6e099ed10d9920da7c17365b3/ash/components/shortcut_viewer_strings.grdp

Comment 12 by wutao@chromium.org, May 22 2018

Status: Fixed (was: Available)

Sign in to add a comment