New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 833949 link

Starred by 1 user
Status: Fixed
Owner:
peter@chromium.org
Closed: May 2018
Cc:
█ pozlen@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Expose the android secret on chrome://gcm-internals

Project Member Reported by peter@chromium.org, Apr 17 2018 
The Android secret is used for authenticating the client when the GCM Driver connects to our GCM servers. It's already observable through chrome://net-internals when a connection is instantiated (encoded in a protobuf), and is stored on-disk in a LevelDB database. This just makes it easier to get to for local debugging.

Since we occasionally ask for screenshots of chrome://gcm-internals it shouldn't be visible by default - displaying it when the user types a phrase should be sufficient.
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f946918f633ace59e3441f41ec47f06b3e1e5626

commit f946918f633ace59e3441f41ec47f06b3e1e5626
Author: Peter Beverloo <peter@chromium.org>
Date: Thu May 03 20:46:52 2018

Add a phrase to display the Android Secret on chrome://gcm-internals

There are good reasons for displaying the Android Secret on this page,
but we need to make sure that users don't include it by accident when
making a screenshot for other reasons.

Following this CL, they can type "secret" to display the Android Secret
that's associated with the already included Android ID.

Bug:  833949 
Change-Id: I20131dbf0f113738cd1f9acd2ece0763db032921
Reviewed-on: https://chromium-review.googlesource.com/1034803
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555861}
[modify] https://crrev.com/f946918f633ace59e3441f41ec47f06b3e1e5626/components/gcm_driver/gcm_client.cc
[modify] https://crrev.com/f946918f633ace59e3441f41ec47f06b3e1e5626/components/gcm_driver/gcm_client.h
[modify] https://crrev.com/f946918f633ace59e3441f41ec47f06b3e1e5626/components/gcm_driver/gcm_client_impl.cc
[modify] https://crrev.com/f946918f633ace59e3441f41ec47f06b3e1e5626/components/gcm_driver/gcm_internals_constants.cc
[modify] https://crrev.com/f946918f633ace59e3441f41ec47f06b3e1e5626/components/gcm_driver/gcm_internals_constants.h
[modify] https://crrev.com/f946918f633ace59e3441f41ec47f06b3e1e5626/components/gcm_driver/gcm_internals_helper.cc
[modify] https://crrev.com/f946918f633ace59e3441f41ec47f06b3e1e5626/components/gcm_driver/resources/gcm_internals.css
[modify] https://crrev.com/f946918f633ace59e3441f41ec47f06b3e1e5626/components/gcm_driver/resources/gcm_internals.html
[modify] https://crrev.com/f946918f633ace59e3441f41ec47f06b3e1e5626/components/gcm_driver/resources/gcm_internals.js

Comment 2 by peter@chromium.org, May 3 2018

Status: Fixed (was: Assigned)
Marking this as fixed. Users will be able to type the word "secret" on chrome://gcm-internals to make the Android Secret visible.
►

Sign in to add a comment