New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833941 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Q2

Blocking:
issue 834671



Sign in to add a comment

Suggested articles on NTP formatted poorly with large text

Project Member Reported by pkl@chromium.org, Apr 17 2018

Issue description

App Version (from "Chrome Settings > About Chrome"): 68.0.3398.0 canary
iOS Version: 11.2.6
Device: iPhone SE

Steps to reproduce: 
0. I use large (but not too large) fonts. Under Settings > General > Accessibility > Larger Text. Toggle on "Larger Accessibility Sizes" and the slider setting is just around the mid-point.
00. I also use French on my phone.
000. Phase 1 flag enabled.
1. Open NTP

Observed behavior: 
1. See attachment. Article title overlaps subtitle.

 
IMG_3043.PNG
307 KB View Download
Labels: zine-triaged
Labels: MS-New-Tab
Owner: justincohen@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by pkl@chromium.org, Apr 19 2018

Blocking: 834671
Labels: Proj-UIRefresh

Comment 5 by marq@chromium.org, Apr 26 2018

Labels: Q2
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4633a457b40fa2f4319776cfc57dac3025ac4bd0

commit 4633a457b40fa2f4319776cfc57dac3025ac4bd0
Author: Justin Cohen <justincohen@google.com>
Date: Mon Apr 30 13:21:50 2018

[ios] Handle larger fonts in content suggestions cell.

Bug:  833941 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iecd425473551185e2c0ff381480a7bddd46cb108
Reviewed-on: https://chromium-review.googlesource.com/1034219
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554733}
[modify] https://crrev.com/4633a457b40fa2f4319776cfc57dac3025ac4bd0/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Issue verified 
Version: Chrome Canary  68.0.3416.0 
Device: iPhone SE, iPhone 6
iOS: 11.3, 11.2.6

Article title does not overlap subtitle.
https://drive.google.com/open?id=1uMboCnRG_tFZXRhiaoZ2zxHkjYVRIAeZ

Sign in to add a comment