Hint text in NTP fake omnibox is longer than available space, runs into voice search mic |
||||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): 68.0.3398.0 canary iOS Version: 11.2.6 Device: iPhone SE Steps to reproduce: 0. I use large (but not too large) fonts. Under Settings > General > Accessibility > Larger Text. Toggle on "Larger Accessibility Sizes" and the slider setting is just around the mid-point. 00. I also use French on my phone. 000. Phase 1 flag enabled. 1. Open NTP Observed behavior: 2. See attachment. Hint text is "Rechercher ou saisir une URL". The word "une" is where it runs into the voice search mic icon. Expected behavior: Not sure what's better. May be use a smaller font inside the fake NTP? Shift text a bit to the left. Fades out the text so it looks truncated and not running into the mic icon? Frequency: Every time
,
Apr 17 2018
,
Apr 17 2018
Just an opinion (can be ignored): Fading the text out before hitting the microphone sounds like a good idea. I think this should be done even if we make the text shorter (at some font size it will still be a problem). Maybe do both fixes :)
,
Apr 18 2018
gambard: Should this be yours? If not, please reassign if you can.
,
Apr 18 2018
,
Apr 19 2018
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7803ea9309d2270c583e0a3dc7027aed2253da5a commit 7803ea9309d2270c583e0a3dc7027aed2253da5a Author: Justin Cohen <justincohen@google.com> Date: Tue May 01 04:55:30 2018 [ios] Update fake omnibox hint text layout and scale. Fix up the width layout of the hint text and update the scaling logic to be a transform rather than a font update. Bug: 833937 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I34ad218645f67f42c3129cb817a7e5be3d704b87 Reviewed-on: https://chromium-review.googlesource.com/1034226 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#554998} [modify] https://crrev.com/7803ea9309d2270c583e0a3dc7027aed2253da5a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h [modify] https://crrev.com/7803ea9309d2270c583e0a3dc7027aed2253da5a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm [modify] https://crrev.com/7803ea9309d2270c583e0a3dc7027aed2253da5a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm [modify] https://crrev.com/7803ea9309d2270c583e0a3dc7027aed2253da5a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/7803ea9309d2270c583e0a3dc7027aed2253da5a/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm [modify] https://crrev.com/7803ea9309d2270c583e0a3dc7027aed2253da5a/ios/chrome/browser/ui/ntp/ntp_header_view_adapter.h
,
May 1 2018
,
May 9 2018
Verified on 68.0.3425.0 Canary in iPhone 5s(iOS 11.2.6) Followed the steps from comment #0. Fake omnibox hint text font size remains same as device font size, text looks truncated and not running in to mic icon. Screenshot: https://drive.google.com/file/d/1BUELdiwQbbkLVZeFnr4i24Yw-mEgi-im/view?usp=sharing |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pkl@chromium.org
, Apr 17 2018240 KB
240 KB View Download