Due to the new OffscreenCanvas submit model: https://github.com/junov/OffscreenCanvasAnimation/blob/master/OffscreenCanvasAnimation.md we need to implement RAF on Workers. This is the tracking bug.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087 commit dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087 Author: Fernando Serboncini <fserb@chromium.org> Date: Mon Apr 23 19:53:12 2018 Creates WorkerAnimationFrameProvider and BeginFrameProvider Both classes work together to provide RequestAnimationFrame to workers. Bug: 833902 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I541b47355ed8ff8cafbb5f4f2b791b2ff16ff4c6 Reviewed-on: https://chromium-review.googlesource.com/1015288 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Olivia Lai <xlai@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#552799} [modify] https://crrev.com/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087/third_party/blink/renderer/core/workers/BUILD.gn [modify] https://crrev.com/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087/third_party/blink/renderer/core/workers/dedicated_worker.cc [modify] https://crrev.com/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087/third_party/blink/renderer/core/workers/global_scope_creation_params.cc [modify] https://crrev.com/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087/third_party/blink/renderer/core/workers/global_scope_creation_params.h [add] https://crrev.com/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087/third_party/blink/renderer/core/workers/worker_animation_frame_provider.cc [add] https://crrev.com/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087/third_party/blink/renderer/core/workers/worker_animation_frame_provider.h [modify] https://crrev.com/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087/third_party/blink/renderer/core/workers/worker_global_scope.h [modify] https://crrev.com/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087/third_party/blink/renderer/platform/BUILD.gn [add] https://crrev.com/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087/third_party/blink/renderer/platform/graphics/begin_frame_provider.cc [add] https://crrev.com/dbd9ed9d3ae16c7fc0f65c1897f8a98dd1256087/third_party/blink/renderer/platform/graphics/begin_frame_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/370a81113be33d30fb33ef2dc90be0e379fb62ef commit 370a81113be33d30fb33ef2dc90be0e379fb62ef Author: Fernando Serboncini <fserb@chromium.org> Date: Tue Apr 24 16:55:00 2018 Worker.RequestAnimationFrame implementation Lazily init CompositorFrameSink on BeginFrameProvider, execute RAF callbacks when requested. Bug: 833902 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I757e8731c9e39d6900109a383630bc1b59ddfead Reviewed-on: https://chromium-review.googlesource.com/1024376 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553162} [modify] https://crrev.com/370a81113be33d30fb33ef2dc90be0e379fb62ef/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/370a81113be33d30fb33ef2dc90be0e379fb62ef/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/370a81113be33d30fb33ef2dc90be0e379fb62ef/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/370a81113be33d30fb33ef2dc90be0e379fb62ef/third_party/blink/renderer/core/workers/worker_animation_frame_provider.cc [modify] https://crrev.com/370a81113be33d30fb33ef2dc90be0e379fb62ef/third_party/blink/renderer/core/workers/worker_animation_frame_provider.h [modify] https://crrev.com/370a81113be33d30fb33ef2dc90be0e379fb62ef/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/370a81113be33d30fb33ef2dc90be0e379fb62ef/third_party/blink/renderer/core/workers/worker_global_scope.h [modify] https://crrev.com/370a81113be33d30fb33ef2dc90be0e379fb62ef/third_party/blink/renderer/core/workers/worker_global_scope.idl [modify] https://crrev.com/370a81113be33d30fb33ef2dc90be0e379fb62ef/third_party/blink/renderer/platform/graphics/begin_frame_provider.cc [modify] https://crrev.com/370a81113be33d30fb33ef2dc90be0e379fb62ef/third_party/blink/renderer/platform/graphics/begin_frame_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4cd98662717564e74d45e9f67ac6a55cb77a62f commit d4cd98662717564e74d45e9f67ac6a55cb77a62f Author: Fernando Serboncini <fserb@chromium.org> Date: Mon Apr 30 18:50:22 2018 Makes OffscreenCanvas dispatch on MainThread and Workers - removes old commit() from OffscreenCanvasRenderingContexts. - makes sure that DidDraw is correctly called and triggers a BeginFrame that will trigger a Dispatch of the frame. Bug: 833902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I08ceeba9e7e00da35977bcc4e96a189b366a856c Reviewed-on: https://chromium-review.googlesource.com/1028559 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#554825} [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/test/data/gpu/pixel_offscreenCanvas_2d_resize_on_worker.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/test/data/gpu/pixel_offscreenCanvas_transfer_after_style_resize.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/test/data/gpu/pixel_offscreenCanvas_transfer_before_style_resize.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_main.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/test/data/gpu/pixel_offscreenCanvas_webgl_resize_on_worker.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/test/data/media/canvas_capture.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces.https-expected.txt [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.commit-expected.txt [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.commit.w-expected.txt [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.commit.w.html [add] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.resize-expected.txt [delete] https://crrev.com/a2c23355cd3429845aededd5dcc614132727607d/third_party/WebKit/LayoutTests/fast/canvas-api/OffscreenCanvas-commit-promise.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/canvas-api/OffscreenCanvas-multiple-worker-commit.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-MessageChannel-transfer.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-copyImage.html [add] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-frameless-doc-expected.txt [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-frameless-doc.html [delete] https://crrev.com/a2c23355cd3429845aededd5dcc614132727607d/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-invalid-call.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-retains-backing.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-placeholder-createImageBitmap.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-placeholder-image-source-with-worker.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-placeholder-image-source.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/webgl/OffscreenCanvas-webgl-preserveDrawingBuffer.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/fast/webgl/offscreenCanvas-APIs-NOT-alter-webgl-states.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/http/tests/security/offscreencanvas-placeholder-read-blocked-no-crossorigin.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/printing/offscreencanvas-2d-printing.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/printing/offscreencanvas-webgl-printing.html [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/core/workers/worker_animation_frame_provider.cc [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/core/workers/worker_animation_frame_provider.h [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/modules/canvas/offscreencanvas/offscreen_canvas_test.cc [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.cc [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.h [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.idl [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.idl [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/platform/BUILD.gn [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/platform/graphics/begin_frame_provider.cc [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/platform/graphics/begin_frame_provider.h [rename] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc [modify] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.h [delete] https://crrev.com/a2c23355cd3429845aededd5dcc614132727607d/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_impl.h [rename] https://crrev.com/d4cd98662717564e74d45e9f67ac6a55cb77a62f/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/114d87bd87e0012899b6c98b01fc6cd9dfb95c0f commit 114d87bd87e0012899b6c98b01fc6cd9dfb95c0f Author: Fernando Serboncini <fserb@chromium.org> Date: Mon Apr 30 18:57:25 2018 Create a single IPC call for OffscreenCanvasProvider For BeginFrameProvider, we don't need the multi-call location. Hence, we can remove one IPC call from the process. Bug: 833902 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id360cd544cfdb6c583f408b083850b30990f4231 Reviewed-on: https://chromium-review.googlesource.com/1032798 Reviewed-by: Justin Novosad <junov@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Olivia Lai <xlai@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#554829} [modify] https://crrev.com/114d87bd87e0012899b6c98b01fc6cd9dfb95c0f/content/browser/renderer_host/offscreen_canvas_provider_impl.cc [modify] https://crrev.com/114d87bd87e0012899b6c98b01fc6cd9dfb95c0f/content/browser/renderer_host/offscreen_canvas_provider_impl.h [modify] https://crrev.com/114d87bd87e0012899b6c98b01fc6cd9dfb95c0f/third_party/blink/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom [modify] https://crrev.com/114d87bd87e0012899b6c98b01fc6cd9dfb95c0f/third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51ce2cacd7f852876a197e716b93e0e63f9aa1ef commit 51ce2cacd7f852876a197e716b93e0e63f9aa1ef Author: Fernando Serboncini <fserb@chromium.org> Date: Tue May 01 17:15:36 2018 Call RAF callbacks with monotonic timestamp Bug: 833902 Change-Id: Iaec0c5d4bff2d9988edc11a3f6c8958a9f34ba63 Reviewed-on: https://chromium-review.googlesource.com/1035904 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#555086} [add] https://crrev.com/51ce2cacd7f852876a197e716b93e0e63f9aa1ef/third_party/WebKit/LayoutTests/fast/workers/worker-requestAnimationFrame.html [modify] https://crrev.com/51ce2cacd7f852876a197e716b93e0e63f9aa1ef/third_party/blink/renderer/core/workers/worker_animation_frame_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88 commit 290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88 Author: Fernando Serboncini <fserb@chromium.org> Date: Thu May 10 16:26:34 2018 update frame sink ids on BeginFrameProvider when GPU crashes Bug: 833902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic9ccf732ab6425c60fb3e2df4d53d239bde5d920 Reviewed-on: https://chromium-review.googlesource.com/1037921 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557549} [modify] https://crrev.com/290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88/content/test/data/gpu/pixel_webgl_sad_canvas.html [add] https://crrev.com/290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88/content/test/data/gpu/pixel_worker_requestAnimationFrame.html [modify] https://crrev.com/290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88/content/test/gpu/gpu_tests/pixel_expectations.py [modify] https://crrev.com/290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88/content/test/gpu/gpu_tests/pixel_test_pages.py [modify] https://crrev.com/290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88/third_party/blink/renderer/core/workers/dedicated_worker.cc [modify] https://crrev.com/290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88/third_party/blink/renderer/core/workers/dedicated_worker.h [modify] https://crrev.com/290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.h [modify] https://crrev.com/290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88/third_party/blink/renderer/platform/graphics/begin_frame_provider.cc [modify] https://crrev.com/290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88/third_party/blink/renderer/platform/graphics/begin_frame_provider.h
Issue 803937 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee749a4e70158c219fd83fd25e3a39b707de7bde commit ee749a4e70158c219fd83fd25e3a39b707de7bde Author: Fernando Serboncini <fserb@chromium.org> Date: Mon May 14 22:01:10 2018 Re-enable Pixel_WorkerRAF_OOPD pixel test Bug: 833902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifc1a9716a293e4e1f9020bb45e2a36336718364f Reviewed-on: https://chromium-review.googlesource.com/1055650 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558483} [modify] https://crrev.com/ee749a4e70158c219fd83fd25e3a39b707de7bde/content/test/gpu/gpu_tests/pixel_expectations.py
This test is Flaky on Android Nvidia: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%209%29/3359 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28NVIDIA%20Shield%20TV%29/2651 Please fix or adjust expectations.
Expectations were fixed in https://chromium-review.googlesource.com/1060014, but wrong bug was attributed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c42a3e76aa04dcd2653a12b44a039647223a039 commit 2c42a3e76aa04dcd2653a12b44a039647223a039 Author: Yuly Novikov <ynovikov@chromium.org> Date: Wed May 16 21:08:47 2018 Update pixel test expectations Pixel_OffscreenCanvas2DResizeOnWorker flaky also on Linux Correct bug number for Pixel_WorkerRAF_OOPD expectation TBR=kbr@chromium.org Bug: 833902 , 840394 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie2d90eedc8b16baec2890f09dd8ef96c40293ada Reviewed-on: https://chromium-review.googlesource.com/1062194 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#559285} [modify] https://crrev.com/2c42a3e76aa04dcd2653a12b44a039647223a039/content/test/gpu/gpu_tests/pixel_expectations.py
Some offscreen canvas tests are flaky, could this be because of these changes? https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/97762 - virtual/threaded/printing/offscreencanvas-2d-printing.html https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/99666 - virtual/disable-spv175/printing/offscreencanvas-2d-printing.html https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/99771 - fast/canvas/OffscreenCanvas-commit-copyImage.html
Does this work in linux at all yet? rAF immediately crashes the browser on viz.mojom.CompositorFrameSinkProxy.SetNeedsBeginFrame All worker types, all versions of Chrome, all machines I have access to.
It does. Could you please create a bug with an example of what is not working for you?
https://bugs.chromium.org/p/chromium/issues/detail?id=860102 A shared worker containing only "requestAnimationFrame(()=>{})" crashes immediately. Service workers are affected. Dedicated workers are not affected.
Comment 1 by bugdroid1@chromium.org
, Apr 23 2018