New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833896 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 833122
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Requested allocation size 0x285be9c758f75400 in AllocateMemoryWithFlags

Project Member Reported by ClusterFuzz, Apr 17 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5500008980545536

Fuzzer: inferno_twister
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Requested allocation size 0x285be9c758f75400
Crash Address: 
Crash State:
  AllocateMemoryWithFlags
  v8::internal::JSArrayBuffer::SetupAllocatingData
  v8::internal::ConstructBuffer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=550607:550608

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5500008980545536

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 18 2018

Labels: M-67
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 18 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 18 2018

Labels: Pri-1

Comment 4 by vakh@chromium.org, Apr 18 2018

Components: Blink>JavaScript
Owner: bbudge@chromium.org
Status: Assigned (was: Untriaged)
Hello bbudge@ -- could you please help find the right owner for this? Thanks.

Comment 5 by bbudge@chromium.org, Apr 18 2018

Cc: palmer@chromium.org eholk@chromium.org
This is a crash when allocating a huge array buffer. It's in AllocateMemoryWithFlags, which inlines a lot of partition_allocator code, so it's hard to tell how the huge size causes a crash. Also, it doesn't reproduce on today's Canary on OSX, giving a range error instead:

Uncaught RangeError: Array buffer allocation failed
    at new ArrayBuffer (<anonymous>)
    at file: ...

cc'ing Erik and Chris who may have ideas on the best fix. We could check for size > the direct mapping limit of 2 GiB in AllocateMemoryWithFlags.

Comment 6 by palmer@chromium.org, Apr 18 2018

Re #5: You could check in the Blink layer, but that would be redundant with the check in the Partition Alloc layer. I guess the inlining is more aggressive than I thought; the PA check is in `PartitionBucket::SlowPathAlloc`.

I'd be a bit concerned about the Blink and PA checks getting out of sync.

I think this bug is pretty much WontFix, working as intended.

Comment 7 by bbudge@chromium.org, Apr 18 2018

I'll try to reproduce the crash on Linux tomorrow just to see where things go wrong.
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 19 2018

Labels: -Security_Impact-Head Security_Impact-Beta

Comment 9 by bbudge@chromium.org, Apr 19 2018

I can't replicate on Linux 64 (tip of tree build this morning). Could this be specific to Linux 32.

Comment 10 by aarya@google.com, Apr 23 2018

Mergedinto: 833122
Status: Duplicate (was: Assigned)
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 31

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment