New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833882 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Jul 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 805543



Sign in to add a comment

partial responses in endpoints_webapp2.py

Project Member Reported by no...@chromium.org, Apr 17 2018

Issue description

Google APIs support a magical query string parameter "fields".
Value format docs: https://cloud.google.com/storage/docs/json_api/v1/how-tos/performance#partial-response


Feature request: add support for "fields" into endpoints_webapp2.py
When fields are specified, strip all other fields from the message returned by the service implementation. Only after that, continue to serializing the message to JSON and responding to the requester.
 

Comment 1 by no...@chromium.org, Apr 17 2018

Blocking: 805543
until we have buildbucket api v2, gerrit-buildbucket plugin will need this feature. Sana, please include it in your Cloud Endpoints migration project

Comment 2 by estaab@chromium.org, May 22 2018

Owner: s...@google.com
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/c5479d4bee0939d1d6401dc51029b1ec5a084870

commit c5479d4bee0939d1d6401dc51029b1ec5a084870
Author: smut <smut@google.com>
Date: Wed Jul 25 23:26:35 2018

[webapp2 adapter] Return partial responses

Bug:  833882 
Change-Id: Ib387c787d2843541b8e3afa581907ac0d429199d
Reviewed-on: https://chromium-review.googlesource.com/1149158
Commit-Queue: smut <smut@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/c5479d4bee0939d1d6401dc51029b1ec5a084870/appengine/components/components/endpoints_webapp2/adapter.py

Cc: -smut@chromium.org
Owner: smut@chromium.org
Status: Fixed (was: Assigned)
🎉
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b95687a07fc680eb1fe0e8d8f976167e22b53bb9

commit b95687a07fc680eb1fe0e8d8f976167e22b53bb9
Author: smut <smut@google.com>
Date: Wed Aug 01 01:45:47 2018

Roll luci-py to db606474e98248472fbfc9a2278f94380e31c07d

Changes:
db606474 [Swarming] Ensure lease_expiration_ts is not None before comparing
920af4af cq.cfg: remove cq_name.
47e502ce Reland "Send spec_name tags to event mon metrics"
d1d13040 [Swarming] Update assertion to account for indefinite leases
de2166f3 [Swarming] Account for unspecified leased_indefinitely value
c5479d4b [webapp2 adapter] Return partial responses
ac302121 [swarming] start_server.py add --leak and print log path
fcc3c00e [swarming] improve README for local dev
be667854 [client] Overhaul temporary directory override in run_isolated
e7c676c3 [Swarming] Handle MP release failure during bot delete API call
a41b71fa [Swarming] Support indefinite leases
ed2e0acd README.md: clarify OAuth instructions for developer instance
55e57661 [swarming] fix local_smoke_test
a1a5e671 [client] lower default task priority to 200
87242d7b Roll infra_libs, gae_event_mon and gae_ts_mon.
dd874b59 [Machine Provider] Fix lint errors and enable pylint presubmit
c9c4e0a0 [Machine Provider] Support indefinite leases

Bug:  833882 
Change-Id: I7d734abc57dc189f80d461382ecacecf8bc07a4c
Reviewed-on: https://chromium-review.googlesource.com/1157660
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/b95687a07fc680eb1fe0e8d8f976167e22b53bb9/DEPS

Sign in to add a comment