New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 833878 link

Starred by 3 users
Status: Fixed
Owner:
█ acondor@chromium.org
Last visit > 30 days ago
Closed: Jul 19
Cc:
dougman@chromium.org
█ gordonbrander@chromium.org
dbbrooks@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR omnibox: Populate field with current URL and a clear button

Project Member Reported by cjgrant@chromium.org, Apr 17 2018 
The omnibox PRD lists a P3 item to pre-populate the text input field with the current URL, selected.

Typing (or pressing backspace) will clear this text, or, placing the cursor will preserve it.

We should probably add this support, and should also consider whether a clear-field button should be added along with the mic button.

Comment 1 by acondor@chromium.org, Jul 16

Owner: acondor@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90bd49618832bfe91dc7237a25be94c462b78f92

commit 90bd49618832bfe91dc7237a25be94c462b78f92
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Tue Jul 17 16:30:53 2018

VR: populate ommnibox with current URL

Bug:  833878 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If087700c9d318711c81bd5a0e50d929e960bd61d
Reviewed-on: https://chromium-review.googlesource.com/1138399
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575669}
[modify] https://crrev.com/90bd49618832bfe91dc7237a25be94c462b78f92/chrome/browser/vr/elements/omnibox_formatting.cc
[modify] https://crrev.com/90bd49618832bfe91dc7237a25be94c462b78f92/chrome/browser/vr/elements/omnibox_formatting.h
[modify] https://crrev.com/90bd49618832bfe91dc7237a25be94c462b78f92/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/90bd49618832bfe91dc7237a25be94c462b78f92/chrome/browser/vr/elements/url_text.cc
[modify] https://crrev.com/90bd49618832bfe91dc7237a25be94c462b78f92/chrome/browser/vr/model/text_input_info.cc
[modify] https://crrev.com/90bd49618832bfe91dc7237a25be94c462b78f92/chrome/browser/vr/model/text_input_info.h
[modify] https://crrev.com/90bd49618832bfe91dc7237a25be94c462b78f92/chrome/browser/vr/ui_scene_creator.cc

Comment 3 by acondor@chromium.org, Jul 17

Labels: -Hotlist-VRB-MVP-Next
Owner: ----
Status: Available (was: Started)
Adding a clear button is still pending.

Comment 4 by dougman@chromium.org, Jul 17

Cc: dougman@chromium.org dbbrooks@chromium.org
Labels: Test-Manual

Comment 5 by acondor@chromium.org, Jul 19

Owner: acondor@chromium.org
Status: Fixed (was: Available)
Opened  issue 865550  to track the clear button.
►

Sign in to add a comment