New issue
Advanced search Search tips

Issue 833858 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Small fix-ups Q2 2018

Project Member Reported by sjg@chromium.org, Apr 17 2018

Issue description

Tracking minor fixes
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2018

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2018

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7d412b050dda8e1732069cdb4f84e4a0b8736c39

commit 7d412b050dda8e1732069cdb4f84e4a0b8736c39
Author: Simon Glass <sjg@chromium.org>
Date: Thu Apr 19 00:35:36 2018

cros-unibuild: Drop install_private_model_file

This is not needed anymore - it is the old way of finding master config
fragments. Remove it.

BUG= chromium:833858 
TEST=trybot to check that grunt and kahlee don't need it

Change-Id: I6e6304746a2b05ad63c39d72f036df20c8ecacf7
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1014957
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/7d412b050dda8e1732069cdb4f84e4a0b8736c39/eclass/cros-unibuild.eclass

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 27 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/2a3f024b2a6619fa59749c147758474262adc41c

commit 2a3f024b2a6619fa59749c147758474262adc41c
Author: Simon Glass <sjg@chromium.org>
Date: Tue Jun 26 19:52:02 2018

cros_config_struct: Clarify config lookup stages

At present we have a fallback from FDT to yaml. Really this is not a great
idea, since if we are using yaml we would want to report errors. But
normally if we are using yaml there is no FDT config, so the effect should
be the same.

But it is useful to see what stage we are at and when we have given up on
finding a yaml config. Add some more debug statements for this.

BUG= chromium:833858 
TEST=FEATURES=test emerge-grunt --nodeps mosys
Run mosys platform model -vvvv

Change-Id: I33b82e2bcf22cdab88372da96a4ac84c3ca93153
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1113901
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/2a3f024b2a6619fa59749c147758474262adc41c/lib/cros_config/cros_config.c

Status: Fixed (was: Started)

Sign in to add a comment