New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833826 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Non-Regression: Notification is getting chopped when docked magnifier is enabled and shelf position is changed to left/right

Project Member Reported by kebalaji@chromium.org, Apr 17 2018

Issue description

Chrome Version: 67.0.3396.8/10575.4.0 dev channel  Daisy,Candy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>>Enable Docked Magnifier>> Change the shelf position to Right/Left, take a screenshot and click on notification icon and observe

Actual: Notification  is seen chopped when docked magnifier is enabled 
Expected: No such issue should be seen 

This is a Non-Regression issue seen from M67

@Yoshiki: Please confirm the issue
 
ActualDMrgt.mp4
9.6 MB View Download
Cc: yoshiki@chromium.org
Owner: yamaguchi@chromium.org
Status: Started (was: Assigned)
I confirmed this happens on 68.0.3424.0.
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/004d768e0d37003e65cfc7e4ab8c7b9a2ad33666

commit 004d768e0d37003e65cfc7e4ab8c7b9a2ad33666
Author: Tatsuhisa Yamaguchi <yamaguchi@google.com>
Date: Tue May 08 07:22:28 2018

Limit web notification bubble height to fit in the user work area.

Change-Id: I1b8f6ab60fd5c871e0c119200a01f4ce091fdd7c
Bug:  833826 
Test: Manually verified by turning on docked magnifier.
Reviewed-on: https://chromium-review.googlesource.com/1049466
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556714}
[modify] https://crrev.com/004d768e0d37003e65cfc7e4ab8c7b9a2ad33666/ash/system/web_notification/web_notification_tray.cc

Status: Fixed (was: Started)
Yamaguchi-san, thank you very much!
Labels: Merge-Request-67
Status: Assigned (was: Fixed)
Sorry, one more thing. Could you merge this to M67?
Project Member

Comment 7 by sheriffbot@chromium.org, May 10 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-67 Merge-Rejected-67
#1 says this is a non-regressing meaning it was in place before M67?

We typically don't merge this late for UI/cosmetic issues. Declining; please re-tag for merge with reasoning if required.
Status: Fixed (was: Assigned)
Thanks for explanation. I think we can have this fix at M68.

I think this issue can only happen after introduction of docked magnifier, which seems to have been available from M66. I haven't confirmed if this was happening on M66, though.

Sign in to add a comment