New issue
Advanced search Search tips

Issue 833825 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

crosvm rtc support on aarch64

Project Member Reported by sonnyrao@chromium.org, Apr 17 2018

Issue description

On ARM we don't seem to be able to pick up the correct time and date.  We get this message from the kernel:

[    0.574527] hctosys: unable to open rtc device (rtc0)

Probably we need to create an ARM version of the RTC device.  X86 seems to use something that uses I/O ports.
 
Labels: Proj-Containers
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2018

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/575612dbd5908e5f6dcd2cf5b43c85b7289c3872

commit 575612dbd5908e5f6dcd2cf5b43c85b7289c3872
Author: Sonny Rao <sonnyrao@chromium.org>
Date: Thu May 03 05:21:01 2018

CHROMIUM: config: arm vm: enable pl030 rtc driver

This is the device that we're emulating in crosvm.

BUG= chromium:833825 
TEST=manual test on kevin

Change-Id: I212bf00c86b9d3060a294c9d7f516737ba269a7f
Signed-off-by: Sonny Rao <sonnyrao@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1038792
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/575612dbd5908e5f6dcd2cf5b43c85b7289c3872/arch/arm64/configs/chromiumos-container-vm-arm64_defconfig

Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/e0823392f4dde29f3bde7f98d0bc481654843d27

commit e0823392f4dde29f3bde7f98d0bc481654843d27
Author: Sonny Rao <sonnyrao@chromium.org>
Date: Fri May 04 10:03:00 2018

devices: add an emulated ARM pl030 RTC clock

This adds a very simple RTC device and implements reading the time of
day based on the host's time of day.  It currently doesn't support
setting the time or wake up alarms but could do so in the future.
Also instantiate it and add the appropriate nodes to the device-tree
for ARM guests.

BUG= chromium:833825 
TEST=manual test on kevin, date is properly set when VM is started

Change-Id: I032ec7df2cba9e9016966eb4160b413fec9a40ba
Reviewed-on: https://chromium-review.googlesource.com/1038801
Commit-Ready: Sonny Rao <sonnyrao@chromium.org>
Tested-by: Sonny Rao <sonnyrao@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/e0823392f4dde29f3bde7f98d0bc481654843d27/aarch64/src/fdt.rs
[modify] https://crrev.com/e0823392f4dde29f3bde7f98d0bc481654843d27/aarch64/src/lib.rs
[add] https://crrev.com/e0823392f4dde29f3bde7f98d0bc481654843d27/devices/src/pl030.rs
[modify] https://crrev.com/e0823392f4dde29f3bde7f98d0bc481654843d27/devices/src/lib.rs

Status: Fixed (was: Assigned)
Components: OS>Systems>Containers

Sign in to add a comment