New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833824 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 733998
Owner:
Closed: Jan 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression : 'Mobile data' toggle button is not enabled for first time at Uber Tray

Project Member Reported by mmanchala@chromium.org, Apr 17 2018

Issue description

Chrome Version: 67.0.3396.8/10575.4.0 dev channel  Daisy,Candy,Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to User -> Insert Mobile Dongle and ensure it is connected
(2)Open Uber tray and go to Network section ->Observe Connected Dongle connection is seen
(3)Now Disable 'Mobile data' toggle button -> again try to Enable and observe toggle button is not enabled for first time i.e. need to enable toggle button again
(Please refer video)

Expected:  'Mobile data' toggle button should be enabled after enabling it for first time
Actual: Instead 'Mobile data' toggle button is not enabled for first time

This is Regression issue as same is working fine in M-63

Note:
1)In M-64, M-65 issue is inconsistent i.e. sometimes for first time toggle button is enabled
2)In M-66 & M-68 issue is consistent

@tbuckley : Please confirm the Issue
 
Actual_ToggleButtonNotEnabledForFirstTime.mp4
11.6 MB View Download
Expected_ToggleButtonBehavior.mp4
10.9 MB View Download
Cc: tbuck...@chromium.org
Labels: -Pri-1 -M-67 Pri-3
Owner: steve...@chromium.org
I found that when disabling and enabling cellular in quick succession we get an error from shill:
 Network: network_handler_callbacks.cc:84 EnableTechnology Failed: cellular: org.chromium.flimflam.Error.Failure: Cannot enable while the device is disabling.

The toggle state just reflects the cellular 'technology enabled' state from shill.

So shill drops the second click and the toggle remains disabled.
That sounds like long standing issue 733998.

When disabling cellular devices we perform at least two operations. These are executed in sequence.
1. Disable modem
2. Power down modem

I think these operations might take a few seconds to complete which causes the odd toggling behavior

see shill::CellularCapabilityUniversal::StopModem


Cc: dsunk...@chromium.org harpreet@chromium.org jessejames@chromium.org benchan@chromium.org
I propose we show a "Disconnecting..." subtitle and keep the toggle enabled after the user tries to disable the mobile data connection.

Once we get notified by shill that the network is disabled we remove the subtitle and disable the toggle.


Mergedinto: 733998
Status: Duplicate (was: Assigned)
Agreed with Tony's assessment in comment#6.

Looking at issue 733998 however, this appears to be a dupe - marking it as such, and copying Tony's suggestion over to that ticket.

Sign in to add a comment