Issue metadata
Sign in to add a comment
|
Regression:Misplacement of background Welcome screen,Shutdown button are seen while rotating the display(90/270) |
||||||||||||||||||||||
Issue descriptionChrome Version:67.0.3396.8/10575.4.0 dev channel Daisy,Candy,Reks OS: Chrome OS What steps will reproduce the problem? (1)Recover Build >>IN OOBE screen, open any sub overlay[Ex: Join network overlay] (2)Rotate the display(Ctrl+Shift+Reload) and observe the misplacement of Welcome screen,Shutdown button Actual: Misplacement of background Welcome screen,Shutdown button are seen while rotating the display(90/270) Expected: No such misplacement should be seen Note: 1. Issue is note seen in Linux,Windows OS 2. Able to reproduce the issue in Sign out,Lock screen too This is a Regression issue as same is working fine in 66.0.3359.102/10452.54.0 beta Attached the screencast for reference.. @alemate : Please confirm the issue.
,
May 22 2018
Is this still an issue? Please provide an update.
,
May 24 2018
This is an RBS; please revert or submit merge request for change.
,
May 29 2018
Please escalate attention / fix/ merge since stable is approaching. There hasn't been an update for the P1 RBS since April 28th; please reconsider RBS status.
,
May 29 2018
I uploaded a one-line fix CL https://chromium-review.googlesource.com/c/chromium/src/+/1076349 and am waiting for review. A lot of dependent CLs have landed, so reverting https://chromium-review.googlesource.com/973682 would be complicated.
,
May 30 2018
Thanks François, can you check on the CL to push it along for submit / testing?
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb90179064ccb9b3586ea2de8f449b1f7c43f006 commit cb90179064ccb9b3586ea2de8f449b1f7c43f006 Author: Francois Doray <fdoray@chromium.org> Date: Wed May 30 19:09:04 2018 Mark the WindowDimmer window as transparent. Any window which isn't fully opaque must be marked as transparent. Otherwise, aura::WindowOcclusionTracker will consider it fully opaque in occlusion computations. Bug: 833814 Change-Id: Ie2cc66319efc3c4c0f3f014a685aa7ca2fff2ef8 Reviewed-on: https://chromium-review.googlesource.com/1076349 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#562948} [modify] https://crrev.com/cb90179064ccb9b3586ea2de8f449b1f7c43f006/ash/BUILD.gn [modify] https://crrev.com/cb90179064ccb9b3586ea2de8f449b1f7c43f006/ash/wm/window_dimmer.cc [add] https://crrev.com/cb90179064ccb9b3586ea2de8f449b1f7c43f006/ash/wm/window_dimmer_unittest.cc
,
May 30 2018
Please submit a merge request after this change is tested on ToT.
,
May 31 2018
Ping since this is schedule impacting. Is #7 the fix, and should it be considered for merge?
,
Jun 1 2018
Request to merge cb90179064ccb9b3586ea2de8f449b1f7c43f006 to M68 branch. This is a trivial fix for a RBS issue.
,
Jun 2 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 4 2018
Merged to branch 3440 https://chromium-review.googlesource.com/c/chromium/src/+/1085027
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f62a33fe592b5490369f631cbd5dad5651811016 commit f62a33fe592b5490369f631cbd5dad5651811016 Author: Francois Doray <fdoray@chromium.org> Date: Mon Jun 04 13:13:46 2018 [Merge M68] Mark the WindowDimmer window as transparent. Any window which isn't fully opaque must be marked as transparent. Otherwise, aura::WindowOcclusionTracker will consider it fully opaque in occlusion computations. Bug: 833814 Change-Id: Ie2cc66319efc3c4c0f3f014a685aa7ca2fff2ef8 Reviewed-on: https://chromium-review.googlesource.com/1076349 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562948}(cherry picked from commit cb90179064ccb9b3586ea2de8f449b1f7c43f006) Reviewed-on: https://chromium-review.googlesource.com/1085027 Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#131} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/f62a33fe592b5490369f631cbd5dad5651811016/ash/BUILD.gn [modify] https://crrev.com/f62a33fe592b5490369f631cbd5dad5651811016/ash/wm/window_dimmer.cc [add] https://crrev.com/f62a33fe592b5490369f631cbd5dad5651811016/ash/wm/window_dimmer_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by alemate@chromium.org
, Apr 28 2018Owner: fdoray@chromium.org