New issue
Advanced search Search tips

Issue 833813 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: May 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

'Close' icon gets overlap with shortcut on enabling RTL in chrome://extension/shortcuts

Reported by shruti.j...@etouch.net, Apr 17 2018 
Chrome Version: 66.0.3359.117 (Official Build) 7f59c28e25283df88e0c6ac8d8b2551d8c6ad93b-refs/branch-heads/3359@{#723}(32/64 bit)
OS:Mac (10.12.6, 10.13.1, 10.13.5)

Pre-Condition:Enable RTL FLag from chrome://flags.

Steps to reproduce:
1.Launch chrome and navigate to 'chrome://extensions/shortcuts'.
2.Set shortcuts for extension and observe the 'close' icon.

Actual Result : 'close' icon gets overlap with shortcut on enabling RTL. 
Expected Result :'close' icon should not get overlap with shortcut on enabling RTL. 

This is a Non-regression issue seen from ‘M-60’ series.

Note:Issue is MAC Specific only.
Kindly review the attached screen-cast .

Thank You!
Actual_Video.mov
2.8 MB View Download

Comment 1 by rbasuvula@chromium.org, Apr 17 2018

Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!

Comment 2 by karandeepb@chromium.org, Apr 27 2018

Components: -Platform>Extensions UI>Browser>ExtensionsManagement

Comment 3 by robliao@chromium.org, Apr 28 2018

Labels: Proj-MaterialDesign-WebUI
Adding Proj-MaterialDesign-WebUI for initial assessment.

Comment 4 by aee@chromium.org, May 21 2018

Owner: aee@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by aee@chromium.org, May 21 2018

Status: Started (was: Assigned)

Comment 6 by aee@chromium.org, May 22 2018 

Screenshot for CL https://chromium-review.googlesource.com/c/chromium/src/+/1068118
extension_shortcut_input_rtl.png
42.1 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8dc9a78716961f13f723a89ac72582554cd32ba

commit d8dc9a78716961f13f723a89ac72582554cd32ba
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue May 22 21:35:22 2018

MD Extensions: show clear shortcut input X on the left for rtl

Bug:  833813 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I608d7ef218b9d8149d49df4cc1f3117fc9c23793
Reviewed-on: https://chromium-review.googlesource.com/1068118
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560787}
[modify] https://crrev.com/d8dc9a78716961f13f723a89ac72582554cd32ba/chrome/browser/resources/md_extensions/shortcut_input.html

Comment 8 by aee@chromium.org, May 22 2018

Status: Fixed (was: Started)

Comment 9 by shruti.j...@etouch.net, May 23 2018

Labels: TE-Verified-68.0.3438.0 TE-Verified-M68
Update : 
Retested above issue in latest Canary  build # 68.0.3438.0 OS:Mac (10.12.6, 10.13.1, 10.13.5) and the issue is fixed. Close icon does not get overlap with shortcut on enabling RTL.  Kindly review an attached screen-cast.

Thank you..!
Canary_Behaviour#68.0.3438.0.mov
3.2 MB View Download
►

Sign in to add a comment