New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833809 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 836865



Sign in to add a comment

Regression : Input pin appears 'white in colour' on tap & hold in bookmark bubble.

Reported by avsha...@etouch.net, Apr 17 2018

Issue description

Chrome Version : 66.0.3359.117 (Official Build) 7f59c28e25283df88e0c6ac8d8b2551d8c6ad93b-refs/branch-heads/3359@{#723} 32/64-bit
OS : Windows 10 Touch device

What steps will reproduce the problem?
1. Launch chrome, open NTP and tap on 'bookmark' (Star) icon seen in omnibox (bookmark bubble opens).
2. In bookmark bubble, single tap in empty area in 'Name' text box (input pin appears in text box).
3. Now tap and hold again in the same empty area in 'Name' text box (release the touch once Cut, Copy options appear) and observe the input pins.

Actual Result : Input pin appears white in colour on tap & hold in bookmark bubble.

Expected Result : Input pin should be seen in blue colour after tap & hold in bookmark bubble.

This is a regression issue, broken in M-66 and providing the bisect using per-revision script:
Good Build : 66.0.3336.0 (Revision : 533410)
Bad Build : 66.0.3338.0 (Revision : 534242)

You are probably looking for a change made after 533720 (known good), but no later than 533721 (first known bad).

CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/ccfa74c42fb68d038a6a995278eff53f287fcc3e..862b32c53e00eb38585da24fbeef838a385b77cf

Suspect : https://chromium.googlesource.com/angle/angle.git/+/f70e0237d4f3ef593b02f0ef974deb0c5c15f697

(Got Auto-Roll group in bisect CL,Hence assigning it to @lucferron)

@lucferron : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. This is touch device specific issue and it can not be reproduced on Win non-touch(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) OS.
2. Issue is also observed on Dev #67.0.3393.4 and Canary #68.0.3398.0
 
Actual_Result.mp4
335 KB View Download
Expected_Result.mp4
407 KB View Download
Input-pin.png
13.7 KB View Download
Labels: ReleaseBlock-Stable
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
Cc: manoranj...@chromium.org
Cc: abdulsyed@chromium.org
Labels: -M-66 -Target-66 M-67
Thank you for the report!

Some reason i'm not seeing this issue on Lenovo (YOGA 710-11IKB) Win10 touch laptop for the reported chrome version#66.0.3359.117.

avshaikh@, can you please double check by resetting all chrome://flags? or on any other Win10 touch device? 

This shouldn't block M66 stable and i'm punting this to M67.

Comment 4 by avsha...@etouch.net, Apr 18 2018

Hi,

Tried resetting all flags from chrome://flags page in reported chrome build #66.0.3359.117 and issue can still be reproduced with all flags reset. Currently we are using Dell (Inspiron 15R) Win-10 touch machine to reproduce this issue.

Note : 
1. Able to repro issue in todays Dev #67.0.3396.10 build as well.
2. Tried re-bisecting and got the same revision again.

Thank you..!!
Thank you for checking. This seems to be hardware/gpu specific and will try to see if i find the same configuration.
I found what might have caused the issue. I'll be reverting the change and then maybe you could test it again on the canary once its available? We do not have the necessary hardware to test that out right now on our end.
Components: Internals>GPU
The change pointed to could not have possibly caused the issue by the way, but this one could maybe have done it: 
https://chromium.googlesource.com/angle/angle.git/+/c0db9addeaebc76c7cc99b26aa27df5e432097ac%5E%21/#F0

avshaikh@, could you also please join a screenshot of the chrome://gpu screen on the device you are able to repro the issue with? 
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/1d97a4d0363da16a8d3ed942c515c0f738ed74e8

commit 1d97a4d0363da16a8d3ed942c515c0f738ed74e8
Author: Luc Ferron <lucferron@chromium.org>
Date: Thu Apr 19 12:15:30 2018

Revert "Fix dEQP renderbuffer unspecified attachment test."

This seems to have caused a regression in Chrome. I'm reverting the
change and suppressing the test that is failing on our end because of
it. Once we can confirm this solves the problem, we'll need some help
investigating further.

This reverts commit c0db9addeaebc76c7cc99b26aa27df5e432097ac.

Bug: angleproject:2321
Bug:  chromium:833809 
Change-Id: I5e40364217e15ae6117f5288a4754b25d983ca0a
Reviewed-on: https://chromium-review.googlesource.com/1017763
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/1d97a4d0363da16a8d3ed942c515c0f738ed74e8/src/tests/deqp_support/deqp_gles3_test_expectations.txt
[modify] https://crrev.com/1d97a4d0363da16a8d3ed942c515c0f738ed74e8/src/libANGLE/FramebufferAttachment.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4abe7b0fa63ea44106468ac4e0a5d67c3dd33c22

commit 4abe7b0fa63ea44106468ac4e0a5d67c3dd33c22
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 19 14:30:32 2018

Roll src/third_party/angle/ eeec3b14c..1d97a4d03 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/eeec3b14cc8d..1d97a4d0363d

$ git log eeec3b14c..1d97a4d03 --date=short --no-merges --format='%ad %ae %s'
2018-04-18 lucferron Revert "Fix dEQP renderbuffer unspecified attachment test."

Created with:
  roll-dep src/third_party/angle
BUG= chromium:833809 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I799a03dabb7ffa079c42dc0bbd6e7a59239a7150
Reviewed-on: https://chromium-review.googlesource.com/1019380
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552010}
[modify] https://crrev.com/4abe7b0fa63ea44106468ac4e0a5d67c3dd33c22/DEPS

The issue should now be fixed, avshaikh@, can you please verify and come back to me?

also, a screenshot of your chrome://gpu page would be really appreciated.
Owner: avsha...@etouch.net
Owner: lucferron@chromium.org
With response to C#10,
 
Retested this issue on Canary build #68.0.3404.0 on Win-10 touch device and the issue is fixed now. Kindly review an attached screen cast of latest canary behaviour and snapshot of chrome://gpu page.

Thank you..!!
Input_pin.mp4
286 KB View Download
chrome_gpu info.png
660 KB View Download
Components: Internals>GPU>ANGLE
avshaikh@etouch.net, is there any way to emulate touch events on a non-touch device, or do we need to purchase a touch device to reproduce this issue? From your about:gpu page you were running on ANGLE's D3D9 back-end, which may explain why other people were not able to reproduce the issue.

To use the D3D9 back-end deliberately the other testers can use --use-angle=d3d9 on the command line.
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.


@Govind, the fix is already in. We're keeping this opened to investigate why we needed to revert our change because it was safe. We want to root cause it and find which component in chrome uses this feature potentially the wrong way and that fix, but it shouldn't be blocking the release.

Can in the chrome team help us reproduce the issue using the flag that Jamie pointed out above? (--use-angle=d3d9)

We might need to merge the fix to a release branch if the revert didn't reach them. We'll need to check if the revert made it into the chromium/3396 branch in ANGLE. Can you check Luc?
Ok I just verified and the revert did not make it to that branch.
Labels: Merge-Request-68 Merge-Request-67
Status: Fixed (was: Assigned)
OK, let's mark marge request. We should do a follow up issue for finding the culprit and re-landing the CL.

Fix is here:

https://chromium-review.googlesource.com/1017763

Should be very safe, and has baked in Canary and been verified externally. Affects Chrome back to M66, but we'll mark merge request in for 67 and 68. 
Project Member

Comment 20 by sheriffbot@chromium.org, Apr 25 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Request-68 -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 for CL: https://chromium-review.googlesource.com/1017763 per comment #19. Pls merge ASAP. Thank you.

M68 is not branched yet so removing "Merge-Request-68" label.
Blocking: 836865
Project Member

Comment 23 by bugdroid1@chromium.org, Apr 25 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/5fd17eb7b7ba2d0b45b1ab12244d8db8ffbcee80

commit 5fd17eb7b7ba2d0b45b1ab12244d8db8ffbcee80
Author: Luc Ferron <lucferron@chromium.org>
Date: Wed Apr 25 18:25:19 2018

Revert "Fix dEQP renderbuffer unspecified attachment test."

This seems to have caused a regression in Chrome. I'm reverting the
change and suppressing the test that is failing on our end because of
it. Once we can confirm this solves the problem, we'll need some help
investigating further.

This reverts commit c0db9addeaebc76c7cc99b26aa27df5e432097ac.

Bug: angleproject:2321
Bug:  chromium:833809 
Change-Id: I5e40364217e15ae6117f5288a4754b25d983ca0a
Reviewed-on: https://chromium-review.googlesource.com/1017763
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
(cherry picked from commit 1d97a4d0363da16a8d3ed942c515c0f738ed74e8)
Reviewed-on: https://chromium-review.googlesource.com/1028490
Reviewed-by: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/5fd17eb7b7ba2d0b45b1ab12244d8db8ffbcee80/src/tests/deqp_support/deqp_gles3_test_expectations.txt
[modify] https://crrev.com/5fd17eb7b7ba2d0b45b1ab12244d8db8ffbcee80/src/libANGLE/FramebufferAttachment.cpp

Is CL listed at #9 need merge to M67?
govind: The CL was merged to the chromium/3396 branch of ANGLE in comment #23, and should be picked up automatically on the next build for M67. I think we're good.
Great, thank you  jmadill@ for confirmation.

Sign in to add a comment