New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833808 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Android: Remove use of CHROME_HEADLESS in pylib.constants.CheckOutputDirectory()

Project Member Reported by digit@chromium.org, Apr 17 2018

Issue description

The CHROME_HEADLESS environment variable is set when building and running tests on bots.

The python function pylib.constants.CheckOutputDirectory() checks this variable when CHROMIUM_OUTPUT_DIR or BUILDTYPE are not defined, in order to auto-detect the current Chromium output directory.

The logic is essentially:

  - Glob all files that match $CHROME_SRC_DIR/out/*/build.ninja
  - If there is only one such file, the use its directory as the new
    value for CHROMIUM_OUTPUT_DIR, otherwise, print an error.
 
According to jbudorick@, we should get rid of this magic, and ensure the bots always set CHROMIUM_OUTPUT_DIR properly before invoking the Python scripts used during the Android build instead.

This entry is to track the issue.
 
Components: Infra
Labels: -Type-Bug Type-Task
Components: -Infra Infra>Client>Chrome
Status: Available (was: Untriaged)
Moving into our backlog for general infra cleanup.

Sign in to add a comment