Issue metadata
Sign in to add a comment
|
Regression : Unnecessary both red and blue focus highlights are seen on textbox on performing undo.
Reported by
pranjali...@etouch.net,
Apr 17 2018
|
||||||||||||||||||||||
Issue descriptionChrome version : 68.0.3398.0 (Official Build) c590f236f50c0b2664bda5d882a10b406af2671c-refs/heads/master@{#551178}(32/64 bit) OS : Windows(7,8,8.1,10) Steps to reproduce: 1.Launch Chrome ,click on bookmark icon on omnibox and Click on 'More..' button . 2.On edit bookmark overlay ,right click on 'URL' textbox and Click on Undo option from context menu. 3.Observe URL textbox. Actual Result : Unnecessary both red and blue focus highlights are seen on textbox after performing undo. Expected Result : Only red focus highlight should be seen on textbox after performing undo. This is a regression issue broken in ‘M-68’ and using the per-revision bisect providing the bisect results, Good build: 68.0.3397.0 (Revision : 550858) Bad build: 68.0.3398.0 (Revision : 551178) Unable to provide the bisect using per-revision script as getting trace back error while doing the bisect. Hence providing the bisect using old bisect script. Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/9d31e1caf65200790d00199728b193a1dcc11c42..b167f41ce785881ea141c39ae1cdc39f5145edfc Suspect: https://chromium.googlesource.com/chromium/src/+/b167f41ce785881ea141c39ae1cdc39f5145edfc @patricialor: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note : Issue is not reproducible on Mac(10.12.6,10.13.1,10.13.5) and Linux(14.04 LTS) OS. Thank you.
,
Apr 18 2018
Thanks so much for finding this! I have a fix up here: https://chromium-review.googlesource.com/c/chromium/src/+/1015455
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31f04533c181c67966c6a4138a54f8cede01bc49 commit 31f04533c181c67966c6a4138a54f8cede01bc49 Author: Patti <patricialor@chromium.org> Date: Thu Apr 19 00:15:54 2018 FocusRing/Views: Fix updating existing focus rings with new colors. Updating an existing focus ring with a new color or corner radius regressed in r550935. This patch fixes it. Bug: 833798 Change-Id: I4896b10ce3a27f5e760f57fa14908e22b471acb1 Reviewed-on: https://chromium-review.googlesource.com/1015455 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#551891} [modify] https://crrev.com/31f04533c181c67966c6a4138a54f8cede01bc49/ui/views/controls/focus_ring.cc
,
Apr 19 2018
Requesting merge to 67 for this because the regressing CL https://chromium.googlesource.com/chromium/src/+/b167f41ce785881ea141c39ae1cdc39f5145edfc was also merged to 67 (see https://bugs.chromium.org/p/chromium/issues/detail?id=829574#c11)
,
Apr 20 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78d6eab8cc7ccf0c7ee4e1733e47333ff268dc4a commit 78d6eab8cc7ccf0c7ee4e1733e47333ff268dc4a Author: Patti <patricialor@chromium.org> Date: Fri Apr 20 01:28:12 2018 FocusRing/Views: Fix updating existing focus rings with new colors. Updating an existing focus ring with a new color or corner radius regressed in r550935. This patch fixes it. Bug: 833798 Change-Id: I4896b10ce3a27f5e760f57fa14908e22b471acb1 Reviewed-on: https://chromium-review.googlesource.com/1015455 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551891}(cherry picked from commit 31f04533c181c67966c6a4138a54f8cede01bc49) Reviewed-on: https://chromium-review.googlesource.com/1020700 Reviewed-by: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#153} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/78d6eab8cc7ccf0c7ee4e1733e47333ff268dc4a/ui/views/controls/focus_ring.cc
,
Apr 20 2018
,
Apr 20 2018
Update : Retested above issue in latest Canary build #68.0.3401.0 on Windows(7,8,8.1,10) OS and the issue is fixed. In latest Canary, only red focus highlight is seen on textbox after performing undo. Kindly review an attached screen-cast. Thank you!
,
Apr 24 2018
Update : Retested above issue in latest dev build #67.0.3396.18 on Windows(7,8,8.1,10) OS and the issue is fixed. In latest dev, only red focus highlight is seen on textbox after performing undo. Kindly review an attached screen-cast. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Apr 17 2018