Merge to M67: Use codec's bitrate limits if SVC is off |
||||||
Issue descriptionThis fixes the regressions in quality and bitrate metrics which were caused by applying SVC rate limits at encoding in single spatial layer. Original bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=9151 Webrtc commit: https://webrtc.googlesource.com/src/+/fafeac3517a8c2c702bf3f65dfe4ac0493eb5874 Which was imported to chromium: https://chromium.googlesource.com/chromium/src/+/c42eb293fc9fab232250d9550fc37f0677ede892
,
Apr 17 2018
Pls apply appropriate OSs label. Thank you.
,
Apr 18 2018
,
Apr 18 2018
Exactly which CL you're requesting a merge for? And is the change well baked in canary, safe to merge?
,
Apr 18 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2018
>>Exactly which CL you're requesting a merge for? Original CL: https://webrtc-review.googlesource.com/69813 CL that merges the fix to M67: https://webrtc-review.googlesource.com/70380 >>And is the change well baked in canary, safe to merge? Local testing of M67 with the fix didn't reveal any issues.
,
Apr 18 2018
CL got auto approved at #5. Pls merge ASAP to M67 as per comment #6. Thank you.
,
Apr 18 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/ce137ce112e025218a2d266bcfd994bdb5fe4588 commit ce137ce112e025218a2d266bcfd994bdb5fe4588 Author: Sergey Silkin <ssilkin@webrtc.org> Date: Wed Apr 18 14:59:18 2018 Merge to M67: Use codec's bitrate limits if SVC is off. Adding SVC rate allocator and layering configurator caused regression for VP9 non-SVC senders. SVC bitrate limits, which were supposed to be used only when spatial layering is enabled, are applied when encoding single spatial layer. E.g. for VP9 360p sender maximum bitrate is limited to 500kbps. This fixes the regression. If sender is configured to send VP9 single layer then codec's bitrate limits are applied to this layer. (cherry picked from commit fafeac3517a8c2c702bf3f65dfe4ac0493eb5874) Bug: chromium:833762 , webrtc:9151 , chromium:831093 Change-Id: Ia1ae4087155ad7917a3443304a21532f1e68ea65 Reviewed-on: https://webrtc-review.googlesource.com/70380 Commit-Queue: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Michael Horowitz <mhoro@webrtc.org> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> Cr-Original-Commit-Position: refs/heads/master@{#22862} Cr-Commit-Position: refs/branch-heads/67@{#2} Cr-Branched-From: 4da18e89bdee78df4478b66cdd0e6f6a38d61b4d-refs/heads/master@{#22779} [modify] https://crrev.com/ce137ce112e025218a2d266bcfd994bdb5fe4588/modules/video_coding/codecs/vp9/svc_rate_allocator.cc [modify] https://crrev.com/ce137ce112e025218a2d266bcfd994bdb5fe4588/modules/video_coding/video_codec_initializer.cc [modify] https://crrev.com/ce137ce112e025218a2d266bcfd994bdb5fe4588/modules/video_coding/video_codec_initializer_unittest.cc
,
Apr 18 2018
Per comment #8, this is already merged to M67. Pls remove "Merge-Approved-67" label if nothing else is pending.
,
Apr 18 2018
,
Jun 7 2018
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?
,
Jun 25 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by gov...@chromium.org
, Apr 17 2018