New issue
Advanced search Search tips

Issue 833748 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-08
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

3D Cube shows backside as front if not rotatet (works on version 65,66)

Reported by bluti...@googlemail.com, Apr 17 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce the problem:
The following example shows the cube with the wrong front (backside is shown as front)
https://codepen.io/anon/pen/yKrZgZ

If the cube is rotated by 1 degree shows up correct:
https://codepen.io/anon/pen/mxgvMM

What is the expected behavior?
front shall be shown of the cube

What went wrong?
backside is shown instead of front

Did this work before? N/A 

Chrome version:  67.0.3393.4  Channel: dev
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 

Comment 1 by woxxom@gmail.com, Apr 17 2018

Bisected to e05ba4c58bde7423528fbb71f61b74543bae919c
"Reland "Draw Occlusion: Enable Draw Occlusion by Default""
Landed in 67.0.3383.0
Confirmed by disabling the CL via "--disable-features=DrawOcclusion" and observing the bug is gone.

To find the underlying bug "--enable-features=DrawOcclusion --enable-draw-occlusion" was used:
Bisect info: 510929 (good) - 510942 (bad)
https://chromium.googlesource.com/chromium/src/+log/03bf954e..bdfa9a0b?pretty=fuller
Suspecting r510942 = bdfa9a0b9a8f7e5704d479d957fe25d675aea4be = https://crrev.com/c/711391 by yiyix@chromium.org
"Optimize overdraw on partially overlapped windows"
Landed in 64.0.3248.0 under chrome://flags/#enable-draw-occlusion

Labels: Needs-Triage-M67
Cc: vamshi.kommuri@chromium.org
Labels: -Type-Bug -Pri-2 ReleaseBlock-Stable Triaged-ET RegressedIn-67 M-67 hasbisect Target-67 FoundIn-67 Target-68 FoundIn-68 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: yixiang@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported chrome version 67.0.3393.4 and on the latest canary 68.0.3399.0 using Windows 10, Ubuntu 14.04 and Mac 10.12.6

Bisect Information:
===================
Last Good Build: 67.0.3382.0
First Bad Build: 67.0.3383.0

Suspecting the same from comment#1
https://chromium.googlesource.com/chromium/src/+/bdfa9a0b9a8f7e5704d479d957fe25d675aea4be

Review URL: https://chromium-review.googlesource.com/711391

Note: Adding RB-Stable as this seems to be a recent regression, please remove if not required.

@yiyix: Please help in assigning it to the right owner if this is not related to your change.

Thanks!

Comment 4 by gov...@chromium.org, Apr 25 2018

M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.


Owner: yiyix@chromium.org
Assigning to correct owner.
*** Bulk Edit ***
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a297c386d902914c424f0a75f74478eb44b1186

commit 7a297c386d902914c424f0a75f74478eb44b1186
Author: yiyix <yiyix@chromium.org>
Date: Sat May 05 08:25:20 2018

Fix regression: 3D objects are not shown correctly

The current draw occlusion cannot handle 3d object yet. This patch allows
DrawOcclusion to skip draw quads from a 3D objects.

Bug:  833748 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I08d12c794d4acff0e1f584f4c74857bc5df83fee
Reviewed-on: https://chromium-review.googlesource.com/1044781
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556323}
[modify] https://crrev.com/7a297c386d902914c424f0a75f74478eb44b1186/components/viz/service/display/display.cc
[modify] https://crrev.com/7a297c386d902914c424f0a75f74478eb44b1186/components/viz/service/display/display_unittest.cc

*** Bulk Edit ***
M67 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.

Comment 9 by yiyix@chromium.org, May 7 2018

The bug is fixed, could anyone verify that it is fixed? So that i can merge to M67?

Thanks.
Labels: Merge-Request-67
Project Member

Comment 11 by sheriffbot@chromium.org, May 7 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by woxxom@gmail.com, May 7 2018

>could anyone verify that it is fixed? 

Verified in r556421.
r556421 good.png
92.0 KB View Download
How is the change listed at #7 looking in canary?

Comment 14 by woxxom@gmail.com, May 7 2018

Canary is same as r556421.
It's just that Canary has font rendering so broken that I didn't want to post a screenshot from there so I chose a more recent build that has fonts fixed.
NextAction: 2018-05-08
The NextAction date has arrived: 2018-05-08
Labels: TE-Verified-M68 TE-Verified-68.0.3424.0
Able to reproduce this issue on reported version 67.0.3393.4, hence verifying the fix on latest canary 68.0.3424.0 using Windows 10, Mac 10.12.6 and Ubuntu 14.04.

Now observing "front" on navigating to codepen given in comment#0.

As fix is working as expected adding TE-Verified labels.

Thanks! 
833748_68.0.3424.0.PNG
553 KB View Download
Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based onc on comment #12 and #17. Pls merge ASAP so we can take it in for tomorrow's beta release. Thank you.
Project Member

Comment 19 by bugdroid1@chromium.org, May 8 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d72bb146bb3c9598aa025141cb660130a0e0443d

commit d72bb146bb3c9598aa025141cb660130a0e0443d
Author: yiyix <yiyix@chromium.org>
Date: Tue May 08 15:51:15 2018

Fix regression: 3D objects are not shown correctly

The current draw occlusion cannot handle 3d object yet. This patch allows
DrawOcclusion to skip draw quads from a 3D objects.

Bug:  833748 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I08d12c794d4acff0e1f584f4c74857bc5df83fee
Reviewed-on: https://chromium-review.googlesource.com/1044781
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556323}(cherry picked from commit 7a297c386d902914c424f0a75f74478eb44b1186)
Reviewed-on: https://chromium-review.googlesource.com/1050385
Reviewed-by: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#516}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/d72bb146bb3c9598aa025141cb660130a0e0443d/components/viz/service/display/display.cc
[modify] https://crrev.com/d72bb146bb3c9598aa025141cb660130a0e0443d/components/viz/service/display/display_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment