New issue
Advanced search Search tips

Issue 833737 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 20
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.9%-39.4% regression in thread_times.tough_scrolling_cases at 550282:550451

Project Member Reported by toyoshim@chromium.org, Apr 17 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 17 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=833737

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=83675d0a97904f512d24414d2d0408afaa7433f7bd21bec647d401f14e81af4e


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
chromium-rel-win7-gpu-nvidia
chromium-rel-win8-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 17 2018

Cc: pmonette@chromium.org chrisha@chromium.org
Owner: pmonette@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/15e7cc46c40000

Wait until after startup to inspect loaded modules by pmonette@chromium.org
https://chromium.googlesource.com/chromium/src/+/ab3074084f4f13af27a18b47c52fbe6968b7a425

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Status: WontFix (was: Assigned)
Closing this bug

Increased CPU time is totally expected from my feature. But the extra work is scheduled on a background thread and should not interfere with foreground work.

In addition, the extra work I am doing is a one time occurrence, that happens shortly after startup. A series of tasks is posted sequentially for each loaded DLL in the process (InspectModule() in module_info_win,h), and each tasks takes less than a second. It may seem long but keep in mind that this runs on a background task. Our metrics shows that the median amount of loaded DLLs for users in the wild is 120.

So unless we see more pref regressions that doesn't involve CPU time, this is working as intended.

Sign in to add a comment