error in main waterfall, clobber builder.

https://ci.chromium.org/buildbot/chromium.fyi/Linux%20x64%20Goma%20Canary%20%28clobber%29/6326

Roll was reverted and roller switch to try run -

It's a huge problem this wasn't caught by the CQ bots. See roll here:

https://chromium-review.googlesource.com/c/chromium/src/+/1014671

All the tests were passing (save for unrelated flakes)

See for example:

https://ci.chromium.org/buildbot/tryserver.chromium.win/win10_chromium_x64_rel_ng/125269

The confirm no-op step is working fine. There appears to be a significant gap in converage.

Build has recovered. Leaving issue open to land the fix.

 Issue 833753  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/c61a24d48fa40bbd41acd1a8d681a83789b6a73a

commit c61a24d48fa40bbd41acd1a8d681a83789b6a73a
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Apr 17 13:10:21 2018

Vulkan: Fix build after roll.

Remove struct_size_helper from LVL build. This was causing
significant problems on the Chromium CQ.

Also fix the warning of duplicate definitions in reg.py by
staging scripts to a temporary folder so we can use a fixed
version.

Bug:  angleproject:2482 
Bug:  chromium:833736 
Change-Id: Ide7202fe14bf6c83419f19bc07113df23d51807a
Reviewed-on: https://chromium-review.googlesource.com/1014902
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[add] https://crrev.com/c61a24d48fa40bbd41acd1a8d681a83789b6a73a/third_party/vulkan-validation-layers/reg.py
[modify] https://crrev.com/c61a24d48fa40bbd41acd1a8d681a83789b6a73a/third_party/vulkan-validation-layers/BUILD.gn

Going to try re-landing the roll now that the fix has landed. CC'ing sheriffs. Note that the open hole regarding coverage on the no-op compile step still exists.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6db6869868929296eaca2c180f766b0f2476008b

commit 6db6869868929296eaca2c180f766b0f2476008b
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Apr 17 20:27:35 2018

Roll src/third_party/angle/ aa8b3982a..aed1b56aa (8 commits)

https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..aed1b56aac8e

$ git log aa8b3982a..aed1b56aa --date=short --no-merges --format='%ad %ae %s'
2018-04-17 jmadill Prerequisite code for simpler GlslangWrapper.
2018-04-13 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation
2018-04-17 lucferron Vulkan: clearRegionWithScissor did not determine the region correctly
2018-04-16 lfy GLES1: gl(Enable|Disable)ClientState
2018-04-17 jmadill Vulkan: Fix build after roll.
2018-04-17 jmadill Vulkan: Suppress ClearIssue test.
2018-04-16 jmadill Vulkan: Disable warning in Mock ICD.
2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18

Created with:
  roll-dep src/third_party/angle
BUG= chromium:833736 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I7c7f1fb47c5cde7e4552f40d084fcd9d1af2e9ee
Reviewed-on: https://chromium-review.googlesource.com/1015624
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551461}
[modify] https://crrev.com/6db6869868929296eaca2c180f766b0f2476008b/DEPS

Sheriffs, heads up, roll just landed.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e470cdeeaf6b81816ff906f28b6db9d30c52a86

commit 9e470cdeeaf6b81816ff906f28b6db9d30c52a86
Author: Michael Wasserman <msw@chromium.org>
Date: Tue Apr 17 22:06:26 2018

Revert "Roll src/third_party/angle/ aa8b3982a..aed1b56aa (8 commits)"

This reverts commit 6db6869868929296eaca2c180f766b0f2476008b.

Reason for revert: Broke compile on Windows
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20%28dbg%29/130690

FAILED: angle_shader_translator.exe angle_shader_translator.exe.pdb  E:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x86 False link.exe /nologo /OUT:./angle_shader_translator.exe /PDB:./angle_shader_translator.exe.pdb @./angle_shader_translator.exe.rsp translator.lib(OutputVulkanGLSL.obj) : fatal error LNK1236: corrupt or invalid COFF sections

Original change's description:
> Roll src/third_party/angle/ aa8b3982a..aed1b56aa (8 commits)
> 
> https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..aed1b56aac8e
> 
> $ git log aa8b3982a..aed1b56aa --date=short --no-merges --format='%ad %ae %s'
> 2018-04-17 jmadill Prerequisite code for simpler GlslangWrapper.
> 2018-04-13 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation
> 2018-04-17 lucferron Vulkan: clearRegionWithScissor did not determine the region correctly
> 2018-04-16 lfy GLES1: gl(Enable|Disable)ClientState
> 2018-04-17 jmadill Vulkan: Fix build after roll.
> 2018-04-17 jmadill Vulkan: Suppress ClearIssue test.
> 2018-04-16 jmadill Vulkan: Disable warning in Mock ICD.
> 2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18
> 
> Created with:
>   roll-dep src/third_party/angle
> BUG= chromium:833736 
> 
> 
> The AutoRoll server is located here: https://angle-chromium-roll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=jmadill@chromium.org
> 
> Change-Id: I7c7f1fb47c5cde7e4552f40d084fcd9d1af2e9ee
> Reviewed-on: https://chromium-review.googlesource.com/1015624
> Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#551461}

TBR=jmadill@chromium.org,angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com

Change-Id: Ic8bf0038e7b39a6025ac24b65aa5a38f078f0ede
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:833736 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1015191
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551492}
[modify] https://crrev.com/9e470cdeeaf6b81816ff906f28b6db9d30c52a86/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ae34c020d385bb63cae7388bccdcc8e9c7f6ca9

commit 6ae34c020d385bb63cae7388bccdcc8e9c7f6ca9
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Apr 18 11:29:32 2018

Roll src/third_party/angle/ aa8b3982a..c90d4d38c (10 commits)

https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..c90d4d38c895

$ git log aa8b3982a..c90d4d38c --date=short --no-merges --format='%ad %ae %s'
2018-04-17 jmadill Fix problematic query in TOutputGLSLBase::visitDeclaration.
2018-04-17 jmadill Revert "Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation"
2018-04-17 jmadill Prerequisite code for simpler GlslangWrapper.
2018-04-13 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation
2018-04-17 lucferron Vulkan: clearRegionWithScissor did not determine the region correctly
2018-04-16 lfy GLES1: gl(Enable|Disable)ClientState
2018-04-17 jmadill Vulkan: Fix build after roll.
2018-04-17 jmadill Vulkan: Suppress ClearIssue test.
2018-04-16 jmadill Vulkan: Disable warning in Mock ICD.
2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18

Created with:
  roll-dep src/third_party/angle
BUG= chromium:833736 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I5d6efbb528d3b927f3f9cc75385be40138ae451c
Reviewed-on: https://chromium-review.googlesource.com/1016171
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551636}
[modify] https://crrev.com/6ae34c020d385bb63cae7388bccdcc8e9c7f6ca9/DEPS