Issue metadata
Sign in to add a comment
|
ArcAccessibilityHelperBridge is crashing after login with dcheck_always_on=true |
||||||||||||||||||||||
Issue descriptionChromium OS built with dcheck_always_on=true keeps crashing after login. Version: Today's ToT (1349ad8ac0e2) Device: samus and caroline [32615:32615:0417/134545.304010:FATAL:observer_list.h(243)] Check failed: false. Observers can only be added once! #0 0x59b184c50c9c base::debug::StackTrace::StackTrace() #1 0x59b184c700e0 logging::LogMessage::~LogMessage() #2 0x59b181f06e89 base::ObserverList<>::AddObserver() #3 0x59b1836ae724 arc::ArcAccessibilityHelperBridge::OnConnectionReady() #4 0x59b18761e4dd arc::internal::ConnectionNotifier::NotifyConnectionReady() #5 0x59b1836b0d55 arc::internal::ConnectionHolderImpl<>::OnConnectionReady() #6 0x59b1836b0e7f _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN3arc8internal20ConnectionHolderImplINS4_5mojom27AccessibilityHelperInstanceENS7_23AccessibilityHelperHostEEEFvNSt3__110unique_ptrIN4mojo7BindingIS9_NSD_19RawPtrImplRefTraitsIS9_EEEENSB_14default_deleteISH_EEEEENS_7WeakPtrISA_EEJSK_EEEvOT_OT0_DpOT1_ #7 0x59b18355b6b7 arc::mojom::AccessibilityHelperInstance_Init_ForwardToCallback::Accept() #8 0x59b185257b58 mojo::InterfaceEndpointClient::HandleValidatedMessage() #9 0x59b1852575c6 mojo::FilterChain::Accept() #10 0x59b185258f12 mojo::InterfaceEndpointClient::HandleIncomingMessage() #11 0x59b18525f32d mojo::internal::MultiplexRouter::ProcessIncomingMessage() #12 0x59b18525e6e0 mojo::internal::MultiplexRouter::Accept() #13 0x59b1852575c6 mojo::FilterChain::Accept() #14 0x59b1852553bb mojo::Connector::ReadSingleMessage() #15 0x59b185255e64 mojo::Connector::ReadAllAvailableMessages() #16 0x59b185255cc6 mojo::Connector::OnHandleReadyInternal() #17 0x59b1827a2734 mojo::SimpleWatcher::DiscardReadyState() #18 0x59b18524f535 mojo::SimpleWatcher::OnHandleReady() #19 0x59b18524fabe _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #20 0x59b184c515ee base::debug::TaskAnnotator::RunTask() #21 0x59b184d1d116 base::internal::IncomingTaskQueue::RunTask() #22 0x59b184c77f16 base::MessageLoop::RunTask() #23 0x59b184c78327 base::MessageLoop::DeferOrRunPendingTask() #24 0x59b184c785a8 base::MessageLoop::DoWork() #25 0x59b184c7b669 base::MessagePumpLibevent::Run() Asano-san, could you triage?
,
Apr 18 2018
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b11dda5b4aad2b1172332b819c536c8e65cc9ee commit 2b11dda5b4aad2b1172332b819c536c8e65cc9ee Author: Yuki Awano <yawano@chromium.org> Date: Fri Apr 20 02:31:51 2018 Remove observer in OnConnectionClosed - Remove observer in OnConnectionClosed instead of Shutdown. Shutdown is called in different life cycle. OnConnectionReady can be called more than once for a single Shutdown call. It can cause helper bridge to register observer more than once. Bug: 833731 Test: None Change-Id: I7057f8d11364687f0d7f9fb5d3b5d213a18e18db Reviewed-on: https://chromium-review.googlesource.com/1018781 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#552236} [modify] https://crrev.com/2b11dda5b4aad2b1172332b819c536c8e65cc9ee/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc [modify] https://crrev.com/2b11dda5b4aad2b1172332b819c536c8e65cc9ee/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by yawano@chromium.org
, Apr 18 2018