New issue
Advanced search Search tips

Issue 833672 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

Remove phases from mb_config.pyl

Project Member Reported by j...@chromium.org, Apr 17 2018

Issue description

Once the Code Search builders are no longer using phases, these can be removed.

Dirk, I'm assigning to you so you can update the description here if necessary. I don't have a complete understanding of everything that needs to be cleaned up here.
 
Components: -Infra>Codesearch Build
Labels: -Restrict-View-Google Build-Tools-MB
Owner: ----
Status: Available (was: Untriaged)
Owner: j...@chromium.org
Status: Started (was: Available)
The Codesearch bots aren't the only ones using phases now, so we can't remove the feature altogether. But I've mailed two CLs to remove Codesearch's usage at least. Once those are in I'll close this bug.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f9e160383a9f0bb65c35f7463a291b5121428d4

commit 7f9e160383a9f0bb65c35f7463a291b5121428d4
Author: Joey Scarr <jsca@google.com>
Date: Thu Aug 16 03:14:48 2018

Remove mb_config phases for codesearch builders.

These are no longer needed. The CS builder recipe is still passing in a phase
argument, but I'm removing that in a separate CL (crrev.com/c/1173943) which
I'll submit at the same time.

Bug:  833672 
Change-Id: I9b273116cc8639116d01b124b7fe3749bda2a8f3
Reviewed-on: https://chromium-review.googlesource.com/1173941
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Joey Scarr <jsca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583520}
[modify] https://crrev.com/7f9e160383a9f0bb65c35f7463a291b5121428d4/tools/mb/mb_config.pyl

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c

commit d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c
Author: Joey Scarr <jsca@google.com>
Date: Thu Aug 16 03:18:59 2018

Remove the phase argument to run_mb.

Each CS builder now only builds for its specific platform, so we can
remove this argument.

This CL should be submitted at the same time as crrev.com/c/1173941.

Bug:  833672 
Change-Id: Ic34668ec338cdcb73e9b90b0e6a72718f5bcaf18
Recipe-Manual-Change: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/1173943
Commit-Queue: Joey Scarr <jsca@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_translation_unit_fail.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_with_revision.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipe_modules/codesearch/api.py
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_win_delete_generated_files_fail.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_compile_fail.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.py
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_generate_compile_database_fail.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_win_test_basic.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_win.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_linux_test_basic.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_linux_test_experimental.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_win_test_experimental.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_win_delete_generated_files_fail.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipe_modules/codesearch/tests/generate_compilation_database.expected/generate_compilation_database_failed.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipe_modules/codesearch/tests/generate_compilation_database.py
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipe_modules/codesearch/examples/full.py
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/README.recipes.md
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android_with_revision.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_win_with_revision.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipe_modules/codesearch/tests/generate_compilation_database.expected/basic.json
[modify] https://crrev.com/d6b0264ff4b1c7fbc36f2b55d5aecdd0e2b5a29c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_with_revision.json

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16

Sign in to add a comment