browser_tests failing on win 10 x64 debug bot |
||
Issue descriptionI'm adding a new builder which runs tests on windows 10 64bit in debug. This appears to have broken several browser_tests suites. This isn't blocking the main waterfall yet, but I'd like to green up this bot and make it a main waterfall bot. Can you take a look and see if this is an infra issue, or a real test failure? https://chromium-swarm.appspot.com/task?id=3ce8c08195d4e910&refresh=10&show_raw=1 is an example of this failure. The specific test is WithScrollEventPhase/DirectManipulationBrowserTest.HWNDReparent/0 (and /1). This fails on several of the different browser tests suites; you can see them all in this sample build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/53
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71df64db31b8e299c9f7072ef3767686794ae3c0 commit 71df64db31b8e299c9f7072ef3767686794ae3c0 Author: chaopeng <chaopeng@chromium.org> Date: Tue Apr 24 20:38:08 2018 Fix DirectManipulationBrowserTest.HWNDReparent in Debug bots The test failed in debug bots because we direct reparent the HWND to another shell and skip full window reparent logic then shell close also overwrite some state. In this patch, we moved shell close to the end of test body. Bug: 833661 Change-Id: I06c639a1c1620fe3a06af2eb6606970a6a86c78c Reviewed-on: https://chromium-review.googlesource.com/1025119 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553259} [modify] https://crrev.com/71df64db31b8e299c9f7072ef3767686794ae3c0/content/browser/renderer_host/direct_manipulation_browsertest.cc
,
Apr 25 2018
Tests are green now. |
||
►
Sign in to add a comment |
||
Comment 1 by chaopeng@chromium.org
, Apr 17 2018