New issue
Advanced search Search tips

Issue 833658 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

video-controls-focus-movement-on-hide.html flaky

Project Member Reported by steimel@chromium.org, Apr 16 2018

Issue description

media/video-controls-focus-movement-on-hide.html is flaky

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/68472

12:48:14.661 2848 worker/1 media/video-controls-focus-movement-on-hide.html output stderr lines:
12:48:14.661 2848   [5468:1620:0414/124810.880:ERROR:audio_manager_win.cc(306)] GetPreferredAudioParameters failed: 80004005
12:48:14.661 2848   [5468:1620:0414/124810.880:ERROR:audio_manager_base.cc(368)] Invalid audio output parameters received; using fake audio path. Channels: 0, Sample Rate: 0, Bits Per Sample: 0, Frames Per Buffer: 0
12:48:14.667 5648 [4798/5349] media/video-controls-focus-movement-on-hide.html failed unexpectedly (asserts failed)
12:48:14.662 2848 worker/1 media/video-controls-focus-movement-on-hide.html failed:
12:48:14.662 2848 worker/1  asserts failed
 
Owner: steimel@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d1896d916e40de19c66ed30ab549471673eb080

commit 9d1896d916e40de19c66ed30ab549471673eb080
Author: Tommy Steimel <steimel@chromium.org>
Date: Wed May 02 21:54:51 2018

Fix flaky video-controls-focus-movement-on-hide layout test

This CL fixes the test by waiting for the "playing" event before
starting to wait for the media controls hide timer.

Bug: 833658
Change-Id: I85b769a970bbcdf862271b275a5454bcebb0791e
Reviewed-on: https://chromium-review.googlesource.com/1040363
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555566}
[modify] https://crrev.com/9d1896d916e40de19c66ed30ab549471673eb080/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9d1896d916e40de19c66ed30ab549471673eb080/third_party/WebKit/LayoutTests/media/video-controls-focus-movement-on-hide.html

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86417fbacf48049927bf602227c297afbb2465f2

commit 86417fbacf48049927bf602227c297afbb2465f2
Author: jonross <jonross@chromium.org>
Date: Thu May 03 19:05:19 2018

Re-Disable Flaking video-controls-focus-movement-on-hide.html
 video-controls-focus-movement-on-hide.html is still flaking heavily on Mac.

 So I'm re-updating the expectations.

Bug: 833658
Change-Id: I80627456e327797b31725970ba3a8438d990f416
Reviewed-on: https://chromium-review.googlesource.com/1042790
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555842}
[modify] https://crrev.com/86417fbacf48049927bf602227c297afbb2465f2/third_party/WebKit/LayoutTests/TestExpectations

Owner: ----
Status: Available (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f128197594369e55a52df4538323ff7bd96dd30e

commit f128197594369e55a52df4538323ff7bd96dd30e
Author: Max Morin <maxmorin@chromium.org>
Date: Fri May 11 09:36:15 2018

Disable flaky video-controls-focus-movement-on-hide.html

Also has issues on 10.13 and a Windows 7 bot.

Tbr: steimel@chromium.org
No-Try: true
Bug: 833658, 841922
Change-Id: If202d5a9750d5e3b96e8022884bd0ed088840466
Reviewed-on: https://chromium-review.googlesource.com/1054235
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557823}
[modify] https://crrev.com/f128197594369e55a52df4538323ff7bd96dd30e/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 7 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c885b1a7bb863bd7090f1d5f59e79ac51147b9c9

commit c885b1a7bb863bd7090f1d5f59e79ac51147b9c9
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed May 16 20:17:01 2018

Replicate existing expectations into virtual/video-surface-layer flavour

This CL replicates existing test expectations for
media/video-controls-focus-movement-on-hide.html
into the virtual/video-surface-layer flavour of the test.

Before this CL:

crbug.com/833658 [ Linux Win Mac ] media/... [ Pass Failure ]
crbug.com/841922 [ Mac10.12 Mac10.13 Win7 ] virtual/video-surface-layer/media/... [ Failure Pass ]

After this CL:

crbug.com/833658 [ Linux Win Mac ] media/... [ Pass Failure ]
crbug.com/841922 [ Linux Win Mac] virtual/video-surface-layer/media/... [ Pass Failure ]

Bug: 833658, 841922
Change-Id: Ib3de8102f5e947215133f42c2dc522d612394789
Reviewed-on: https://chromium-review.googlesource.com/1062587
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559260}
[modify] https://crrev.com/c885b1a7bb863bd7090f1d5f59e79ac51147b9c9/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment