process_mitigations_unittest failing on windows 10 debug |
|||
Issue descriptionI'm adding a new builder which runs tests on windows 10 64bit in debug. This appears to have broken sbox_integration_tests; specifically process_mitigations_unittest. This isn't blocking the main waterfall yet, but I'd like to green up this bot and make it a main waterfall bot. Can you take a look and see if this is an infra issue, or a real test failure? https://chromium-swarm.appspot.com/task?id=3ce8c181e08e6810&refresh=10&show_raw=1 is a sample test failure. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29 is the builder.
,
Apr 18 2018
Quick question Stephen: The existing bots seem to have very different "steps". I would usually go into the "generate_build_files" step stdout to see the build arguments in args.gn used. Example existing bot: - https://ci.chromium.org/buildbot/tryserver.chromium.win/win10_chromium_x64_rel_ng/125120 - Important bit out of stdout: Writing """\ dcheck_always_on = true goma_dir = "C:\\b\\c\\goma_client" is_component_build = false is_debug = false strip_absolute_paths_from_debug_symbols = true symbol_level = 1 use_goma = true """ to C:\b\c\b\win\src\out\Release_x64\args.gn. Example failure run from your debug bot: - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/86 1) Why are the steps so different? 2) Where can I find output of the args.gn values used in the build? Thanks!
,
Apr 18 2018
This is a tester; it gets triggered by a builder, which does the compilation and then enqueues a request to run a build. So, you need to look at "Win x64 Builder (dbg)" to see what gn args are set on that bot. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20x64%20Builder%20%28dbg%29/229 is an example build. The gn args from that are Writing """\ goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma_client" is_component_build = true is_debug = true strip_absolute_paths_from_debug_symbols = true symbol_level = 1 use_goma = true """ to C:\b\swarming\w\ir\cache\builder\src\out\Debug_x64\args.gn.
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f578508a68147114f8170f79559e06ba19593e9 commit 0f578508a68147114f8170f79559e06ba19593e9 Author: Penny MacNeil <pennymac@chromium.org> Date: Tue Apr 24 18:13:39 2018 [Windows Sandbox] Debug bot test failure "fix". Remove debug-build aslr policy-set test. It's been failing all along, but this is the first time we've turned on a debug Win bot. Follow-up work / cleanup expected to follow. Ref: crbug/834907 BUG= 833648 TEST=sbox_integration_tests.exe, ProcessMitigationsTest.CheckWin8AslrPolicySuccess Change-Id: I5bd538a1be03020b3dd4e355a3ebbd0a066adf7d Reviewed-on: https://chromium-review.googlesource.com/1020153 Reviewed-by: James Forshaw <forshaw@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#553202} [modify] https://crrev.com/0f578508a68147114f8170f79559e06ba19593e9/sandbox/win/src/process_mitigations_unittest.cc
,
Apr 24 2018
Landed a "fix" for this test suite Stephen. Can we do a quick new test run to ensure at least sbox_integration_tests passes now?!
,
Apr 25 2018
It looks like that test suite is no longer failing at head, looking at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29
,
Apr 25 2018
Fabulous, thanks for confirming. Is there a way for me to select this as an optional Windows trybot from a Gerrit CL? Or is this only running against head on the main waterfall at the moment? Once it's green, I hope it will be in the default trybots... is that the idea? If I manually 'choose trybots' in Gerrit, I get the options seen in the attached file snapshot. The default CQ/Dry-run run for a CL includes only: - win10_chromium_x64_rel_ng - win7_chromium_rel_ng - win_chromium_compile_dbg_ng (compile only, not available as a manual 'choose trybots') Thanks Stephen!
,
Apr 25 2018
Yeah, there's no trybot for it right now. I probably should make one so that people can test fixes to tests that are broken right now.
,
Apr 25 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by penny...@chromium.org
, Apr 17 2018