New issue
Advanced search Search tips

Issue 833645 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Task_manager_view focus ring is not correctly updated.

Project Member Reported by wutao@chromium.org, Apr 16 2018

Issue description

ToT as 68.0.3398.0

1. Open task manager by "Search + Esc"
2. Enter immersive mode by pressing F4
3. "Tab" to show focus ring on the table
4. Exit immersive mode by pressing F4

The focus ring is not correctly update.
 
Screenshot 2018-04-16 at 09.40.20.png
211 KB View Download

Comment 1 by ovanieva@google.com, Apr 17 2018

Labels: -Type-Bug Type-Bug-Regression
Owner: warx@chromium.org
Status: Assigned (was: Available)
please triage, looks like window manager issue, likely regression as working on my M66, but not working on TOT

Comment 2 by warx@chromium.org, Jun 26 2018

Owner: ----
Status: Untriaged (was: Assigned)

Comment 3 by sczs@chromium.org, Jun 27 2018

Labels: -OS-iOS
Owner: ovanieva@chromium.org
Cc: sky@chromium.org
Owner: msw@chromium.org
Status: Assigned (was: Untriaged)
msw@ are you the owner of the TableView?

Comment 6 by msw@chromium.org, Jun 30 2018

Owner: wutao@chromium.org
Tao, can you please bisect to find the culprit? I haven't been working on this lately.

Comment 7 by wutao@chromium.org, Jun 30 2018

Sure. I will bisect.

Currently, I think it is because the TableView does not get correct TopInset when restoring from the Fullscreen mode.

Currently bisect indicates that the culprit cl is in the range of:
Bad: 10575.1.0 / 67.0.3396.0
Good: 	10575.0.0 / 67.0.3390.0

Hi Oshima,

Looks there is a cl [1] in that range 67.0.3390.0 - 67.0.3396.0 to calculate the top border height in CustomFrameViewAsh.

Do you think it is related? Thanks!

[1] https://chromium-review.googlesource.com/c/chromium/src/+/999967.

That probably means that focus ring update isn't listening to the correct event when window bounds is updated?
Cc: wutao@chromium.org
Owner: osh...@chromium.org
Hi oshima@, would you please find an owner for this. Thanks.
Cc: tapted@chromium.org msw@chromium.org
tapted@ or msw@ if they know who can work on this.
Status: Fixed (was: Assigned)
It was immersive frame issue and should have been fixed.

Sign in to add a comment