DeviceConditions has a somewhat confusing API and would benefit from a consolidation of its implementation for getting the full current status.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5cdc23e760451e109067281966be7137c23a9e3 commit b5cdc23e760451e109067281966be7137c23a9e3 Author: Carlos Knippschild <carlosk@chromium.org> Date: Fri Apr 27 01:27:45 2018 Improve DeviceConditions API and implementation. Improves the DeviceConditions API by removing unnecessary parameters and renaming its methods to clearly differentiate between static and instance ones. Also improves its implementation a bit by extracting some code into new private methods that are reused by the individual and "get all" static calls. Bug: 833644 Change-Id: I5ccb1430f0b9984cda6345b4c101718cc59e0b9d Reviewed-on: https://chromium-review.googlesource.com/1028854 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#554255} [modify] https://crrev.com/b5cdc23e760451e109067281966be7137c23a9e3/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java [modify] https://crrev.com/b5cdc23e760451e109067281966be7137c23a9e3/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/DeviceConditions.java [modify] https://crrev.com/b5cdc23e760451e109067281966be7137c23a9e3/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflineBackgroundTask.java [modify] https://crrev.com/b5cdc23e760451e109067281966be7137c23a9e3/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/b5cdc23e760451e109067281966be7137c23a9e3/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/prefetch/OfflineNotificationBackgroundTask.java [modify] https://crrev.com/b5cdc23e760451e109067281966be7137c23a9e3/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTask.java [modify] https://crrev.com/b5cdc23e760451e109067281966be7137c23a9e3/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflineBackgroundTaskTest.java [modify] https://crrev.com/b5cdc23e760451e109067281966be7137c23a9e3/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/ShadowDeviceConditions.java [modify] https://crrev.com/b5cdc23e760451e109067281966be7137c23a9e3/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/prefetch/OfflineNotificationBackgroundTaskUnitTest.java [modify] https://crrev.com/b5cdc23e760451e109067281966be7137c23a9e3/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskUnitTest.java
Comment 1 by carlosk@chromium.org
, Apr 16 2018