New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833642 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Textfield's GetSelectedText() and text() is error prone

Project Member Reported by spqc...@chromium.org, Apr 16 2018

Issue description

The GetSelectedText() and text() method in Views textfield is error prone since it relies on the call sites to take care of not revealing the text for password.

 

Comment 1 by msw@chromium.org, Apr 17 2018

Cc: msw@chromium.org
I'm not sure the functions themselves are error prone. Typically, code managing the textfield knows if it's a password field. It's easy enough for other code interacting with the textfield to check for TEXT_INPUT_TYPE_PASSWORD. We could add something like GetDisplayText, to access the corresponding RenderText object function and get the obscured text, but I'm not sure that has much value.
I'm more concerned that outside code that interact with the textfield might forget to check that the textfield might be a password field.
Status: WontFix (was: Assigned)

Sign in to add a comment