New issue
Advanced search Search tips

Issue 833625 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

"net/data/ssl" is an odd path to use in EmbeddedTestServer::AddDefaultHandlers in url_request_unittest.cc

Project Member Reported by nhar...@chromium.org, Apr 16 2018

Issue description

In url_request_unittest.cc, there are several calls to EmbeddedTestServer::AddDefaultHandlers with an argument of base::FilePath(FILE_PATH_LITERAL("net/data/ssl"))). As far as I can tell, these tests are never serving files from the net/data/ssl directory, and these calls are simply to set up the default handlers on the embedded test server.

It looks like all of these calls can be replaced by a call to net::test_server::RegisterDefaultHandlers(EmbeddedTestServer*).
 

Comment 1 by mmenke@chromium.org, Apr 25 2018

Labels: Network-Triaged

Sign in to add a comment