New issue
Advanced search Search tips

Issue 833615 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros: Log spam: NetworkTypePattern: wifi: Can not match empty type.

Project Member Reported by jamescook@chromium.org, Apr 16 2018

Issue description

This happens on linux-chromeos browser_tests and confuses people into thinking there's a real error (e.g.  issue 829310  re: FileManagerBrowserTest, specifically https://bugs.chromium.org/p/chromium/issues/detail?id=829310#c11 )

Can this warning be removed, or at least suppressed on desktop builds?

Steven, can you triage?

 
Labels: -Pri-3 M-68 Pri-2
Yeah, I need to fix this. I need to fix the call sites instead of removing the warning.

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b06cf2ba12275457bcadc96aa43577fbfb2432d4

commit b06cf2ba12275457bcadc96aa43577fbfb2432d4
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Apr 26 18:33:59 2018

Network: Fake Shill Impl: Fix early notifications

This eliminates property set notifications during the initial device
setup in FakeShillManagerClient by adding a 'notify_changed'
parameter to SetDeviceProperty.

Initial notifications were triggering change events before a device was
initial setup, generating bogus error spam.

For trivial change to device_status_collector_browsertest.cc:
TBR=emaxx@chromium.org

Bug:  833615 
Change-Id: I4a841a50e0934129cf33f580b13f87dfa92e9085
Reviewed-on: https://chromium-review.googlesource.com/1023034
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554094}
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/ash/system/network/network_icon_unittest.cc
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/chrome/browser/ui/ash/network/data_promo_notification_unittest.cc
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/chromeos/dbus/fake_shill_device_client.cc
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/chromeos/dbus/fake_shill_device_client.h
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/chromeos/dbus/fake_shill_manager_client.cc
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/chromeos/dbus/shill_device_client.h
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/chromeos/network/network_connect_unittest.cc
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/chromeos/network/network_device_handler_unittest.cc
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/chromeos/network/network_state_handler_unittest.cc
[modify] https://crrev.com/b06cf2ba12275457bcadc96aa43577fbfb2432d4/extensions/browser/api/networking_private/networking_private_chromeos_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment