New issue
Advanced search Search tips

Issue 833612 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

Android content_browsertests timing out with NetworkService enabled

Project Member Reported by cco3@chromium.org, Apr 16 2018

Issue description

Examples of timing out tests:
DataUrlNavigationBrowserTest.HTML_NavigationFromFrame_Block
DataUrlNavigationBrowserTest.OctetStream_BrowserInitiated_Download
DataUrlNavigationBrowserTest.OctetStream_NavigationFromFrame_Download
DataUrlNavigationBrowserTest.PDF_WindowOpenFromFrame_TopFrameIsDataURL_Block
CrossSiteTransferTest.MaliciousPostWithFileData
CrossSiteTransferTest.ReplaceEntryCrossProcessThenTransfer
CrossSiteTransferTest.ReplaceEntryCrossProcessTwice

https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20Android/3299

This is fixed by reverting bc5d4eab42fed9be7a4e530858fce038fcbcdcc3, but this changed is marked as fixing a regression, so it's not clear that it's safe to revert.
https://chromium-review.googlesource.com/c/chromium/src/+/988220
 

Comment 1 by cco3@chromium.org, Apr 17 2018

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e72048ce84dc535bdf055833b80041f99ef2dc0

commit 1e72048ce84dc535bdf055833b80041f99ef2dc0
Author: Conley Owens <cco3@chromium.org>
Date: Tue Apr 17 01:04:50 2018

Revert "Fix content_shell with network service enabled not loading pages."

This reverts commit bc5d4eab42fed9be7a4e530858fce038fcbcdcc3.

Reason for revert: This change breaks numerous tests on Android with NetworkService enabled.

BUG= 833612 

Original change's description:
> Fix content_shell with network service enabled not loading pages.
> 
> This regressed in my earlier cl r528763.
> 
> Change-Id: I06513d517eaa96373628772159f639388fdea1db
> Reviewed-on: https://chromium-review.googlesource.com/988220
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547221}

TBR=jcivelli@chromium.org,jam@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I1d3a83c789b845ec88e92cd9f81b0fe39993d01b
Reviewed-on: https://chromium-review.googlesource.com/1012736
Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551201}
[modify] https://crrev.com/1e72048ce84dc535bdf055833b80041f99ef2dc0/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/1e72048ce84dc535bdf055833b80041f99ef2dc0/content/shell/app/shell_main_delegate.h
[modify] https://crrev.com/1e72048ce84dc535bdf055833b80041f99ef2dc0/content/shell/utility/shell_content_utility_client.cc
[modify] https://crrev.com/1e72048ce84dc535bdf055833b80041f99ef2dc0/content/shell/utility/shell_content_utility_client.h
[modify] https://crrev.com/1e72048ce84dc535bdf055833b80041f99ef2dc0/content/test/content_test_launcher.cc

Comment 4 by jam@chromium.org, May 22 2018

Status: Fixed (was: Assigned)

Sign in to add a comment