This is the root cause of bug 833338. I mixed different coordinates (local and visual) in LayoutObject::PartialInvalidationRect(). For the first step I will just disable partial invalidation to fix bug 833338 in trunk and M67.
Selection in multicol is also broken.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcab7111163d5b72a1300ec0558f9ded347d35bb commit dcab7111163d5b72a1300ec0558f9ded347d35bb Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Apr 17 19:33:46 2018 [SPv175+] Disable partial raster invalidation For now partial raster invalidation of SPv175+ is buggy. Disable it first to fix regressions. Pinpoint job for smoothness.tough_canvas_cases benchmark doesn't show performance regressions of this CL: https://pinpoint-dot-chromeperf.appspot.com/job/14b05086c40000 Bug: 833338, 833598 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I52545c5cc757f045afa3df1c98221a28f25d5689 Reviewed-on: https://chromium-review.googlesource.com/1013298 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#551435} [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/canvas-putImageData-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/text-selection-rect-in-overflow-2-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/paint/invalidation/canvas-putImageData-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/repaint-across-writing-mode-boundary-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-rl-expected.txt [add] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-within-composited-scroller-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/text-selection-rect-in-overflow-2-expected.txt [add] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/mac-mac10.12/paint/invalidation/selection/selection-change-in-iframe-with-relative-parent-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/repaint-across-writing-mode-boundary-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt [add] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selection-change-in-iframe-with-relative-parent-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selection-rl-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/repaint-across-writing-mode-boundary-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/selection-rl-expected.txt [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/blink/renderer/core/paint/object_paint_invalidator_test.cc [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/blink/renderer/platform/graphics/paint/paint_controller.cc [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/blink/renderer/platform/graphics/paint/paint_controller_test.cc [modify] https://crrev.com/dcab7111163d5b72a1300ec0558f9ded347d35bb/third_party/blink/renderer/platform/runtime_enabled_features.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55f8defce4d1b09d5e2534a52de1655a83e460de commit 55f8defce4d1b09d5e2534a52de1655a83e460de Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Apr 19 17:20:35 2018 [SPv175+] Disable partial raster invalidation For now partial raster invalidation of SPv175+ is buggy. Disable it first to fix regressions. Pinpoint job for smoothness.tough_canvas_cases benchmark doesn't show performance regressions of this CL: https://pinpoint-dot-chromeperf.appspot.com/job/14b05086c40000 TBR=wangxianzhu@chromium.org (cherry picked from commit dcab7111163d5b72a1300ec0558f9ded347d35bb) Bug: 833338, 833598 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I52545c5cc757f045afa3df1c98221a28f25d5689 Reviewed-on: https://chromium-review.googlesource.com/1013298 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551435} Reviewed-on: https://chromium-review.googlesource.com/1019864 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#131} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/canvas-putImageData-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/text-selection-rect-in-overflow-2-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/paint/invalidation/canvas-putImageData-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/repaint-across-writing-mode-boundary-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-rl-expected.txt [add] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-within-composited-scroller-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/text-selection-rect-in-overflow-2-expected.txt [add] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/mac-mac10.12/paint/invalidation/selection/selection-change-in-iframe-with-relative-parent-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/repaint-across-writing-mode-boundary-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt [add] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selection-change-in-iframe-with-relative-parent-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selection-rl-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/repaint-across-writing-mode-boundary-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/selection-rl-expected.txt [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/blink/renderer/core/paint/object_paint_invalidator_test.cc [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/blink/renderer/platform/graphics/paint/paint_controller.cc [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/blink/renderer/platform/graphics/paint/paint_controller_test.cc [modify] https://crrev.com/55f8defce4d1b09d5e2534a52de1655a83e460de/third_party/blink/renderer/platform/runtime_enabled_features.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33e7ed7c79637d89d32fc6e8b0081155b11c6952 commit 33e7ed7c79637d89d32fc6e8b0081155b11c6952 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon Jun 04 22:06:37 2018 [SPv175+] Fix partial raster invalidation Split FragmentData::PartialInvalidationRect() into - PartialInvalidationLocalRect() which saves the partial invalidation rect in local coordinates set by InvalidatePaintRectangle() before PrePaint. - PartialInvalidationVisualRect() which saves accumulated partial invalidation rects (including changed selection rects) mapped into visual rect coordinates. The former is mapped and added into the latter, and cleared during PrePaint. The latter is cleared after raster invalidation is issued. The previous wrong implementation was based on a wrong assumption that PrePaint always followed by a Paint, and used the same field to store partial invalidation rect in local and visual coordinates. However, sometimes we may update document lifecycle to PrePaintClean multiple times before a full update. Bug: 833598 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I75e2cf18ec7ee7ad703afb118e9d21f4898aa4d1 Reviewed-on: https://chromium-review.googlesource.com/1083131 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564259} [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/canvas-putImageData-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt [add] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/japanese-rl-selection-clear-expected.txt [add] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/japanese-rl-selection-repaint-expected.txt [add] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/repaint-rect-for-vertical-writing-mode-with-positioned-root-expected.txt [add] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-after-delete-expected.txt [add] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-after-remove-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-change-in-iframe-with-relative-parent-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-clear-expected.txt [add] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-in-composited-scrolling-container-expected.png [add] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-in-composited-scrolling-container-expected.txt [add] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-in-non-composited-scrolling-container-expected.png [add] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-in-non-composited-scrolling-container-expected.txt [add] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.png [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-rl-expected.txt [add] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-within-composited-scroller-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/text-selection-rect-in-overflow-2-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/paint/invalidation/canvas-putImageData-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/repaint-across-writing-mode-boundary-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-rl-expected.txt [delete] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/selection-within-composited-scroller-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/text-selection-rect-in-overflow-2-expected.txt [delete] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/third_party/WebKit/LayoutTests/platform/mac-mac10.12/paint/invalidation/selection/selection-change-in-iframe-with-relative-parent-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/repaint-across-writing-mode-boundary-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt [delete] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selection-change-in-iframe-with-relative-parent-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selection-rl-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/repaint-across-writing-mode-boundary-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/selection-rl-expected.txt [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/core/layout/api/line_layout_item.h [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/core/layout/line/inline_box.cc [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/core/layout/line/inline_box.h [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/core/paint/fragment_data.h [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/core/paint/ng/ng_paint_fragment.cc [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/core/paint/ng/ng_paint_fragment.h [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/core/paint/object_paint_invalidator.cc [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/core/paint/object_paint_invalidator_test.cc [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/platform/graphics/paint/display_item_client.h [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/platform/graphics/paint/paint_controller.cc [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/platform/graphics/paint/paint_controller.h [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/platform/graphics/paint/paint_controller_test.cc [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/platform/graphics/paint_invalidation_reason.h [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/platform/runtime_enabled_features.json5 [modify] https://crrev.com/33e7ed7c79637d89d32fc6e8b0081155b11c6952/third_party/blink/renderer/platform/testing/fake_display_item_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0fe2aac5466bc92bba797593fb9114aa4372ad9 commit a0fe2aac5466bc92bba797593fb9114aa4372ad9 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Jun 05 00:46:25 2018 Rebaseline paint/invalidation/selection/invalidation-rect-with-br-includes-newline.html on Windows TBR=wangxianzhu@chromium.org Bug: 833598 Change-Id: I400b2b07c60a712a516d3322904933ff6bc5ed9f Reviewed-on: https://chromium-review.googlesource.com/1086376 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564319} [modify] https://crrev.com/a0fe2aac5466bc92bba797593fb9114aa4372ad9/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection/invalidation-rect-with-br-includes-newline-expected.txt
Comment 1 by wangxianzhu@chromium.org
, Apr 17 2018