arc: Default app icons are not loaded in case of provisioning is not finished |
||||||
Issue description1. Start new user flow. 2. Don't wait ARC booted. Sign out. 3. Login user session again. 4. Open Launcher and see that ARC default apps has default icon (Play Book for example). Expected that icons are loaded. The same effect happens in case of crash during new user flow setup.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa4e005ad4fd58ee383c7bea32512af7252ec456 commit aa4e005ad4fd58ee383c7bea32512af7252ec456 Author: khmel@google.com <khmel@google.com> Date: Tue Apr 17 00:23:58 2018 arc: Fix default ARC app icons are not loaded. This fix the issue when default ARC app icons are not loaded in case of provisioning is not finished for new user flow. Test: Manually + unit_test Bug: 833596 Change-Id: I99af81eafb78c65857b6fe5a6475d3372e08beb5 Reviewed-on: https://chromium-review.googlesource.com/1014326 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551182} [modify] https://crrev.com/aa4e005ad4fd58ee383c7bea32512af7252ec456/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/aa4e005ad4fd58ee383c7bea32512af7252ec456/chrome/browser/ui/app_list/arc/arc_app_test.cc [modify] https://crrev.com/aa4e005ad4fd58ee383c7bea32512af7252ec456/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
,
Apr 17 2018
,
Apr 17 2018
Can we confirm if this is a M67 regression? Did this work prior to M67, or is this a new feature under development?
,
Apr 17 2018
This is regression and probably even earlier than M67. Not very popular. I think it happens due app launcher refactoring when timing changed.
,
Apr 18 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2018
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/624d1dafb886d34b2c633ad466e36e1da46f1724 commit 624d1dafb886d34b2c633ad466e36e1da46f1724 Author: khmel@google.com <khmel@google.com> Date: Wed Apr 18 01:22:16 2018 [Merge M67] arc: Fix default ARC app icons are not loaded. This fix the issue when default ARC app icons are not loaded in case of provisioning is not finished for new user flow. TBR=khmel@google.com (cherry picked from commit aa4e005ad4fd58ee383c7bea32512af7252ec456) Test: Manually + unit_test Bug: 833596 Change-Id: I99af81eafb78c65857b6fe5a6475d3372e08beb5 Reviewed-on: https://chromium-review.googlesource.com/1014326 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551182} Reviewed-on: https://chromium-review.googlesource.com/1016121 Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#70} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/624d1dafb886d34b2c633ad466e36e1da46f1724/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/624d1dafb886d34b2c633ad466e36e1da46f1724/chrome/browser/ui/app_list/arc/arc_app_test.cc [modify] https://crrev.com/624d1dafb886d34b2c633ad466e36e1da46f1724/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
,
Apr 18 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by khmel@chromium.org
, Apr 16 2018