Add hotword detection to media perception private API |
|||||||
Issue descriptionThis is needed to enable voice control feature in Hangouts Meet on Chromebox For Meetings.
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/283e9fa129d3d4cf5c6f6ed1dab4ad15159d3fbb commit 283e9fa129d3d4cf5c6f6ed1dab4ad15159d3fbb Author: Wei Guan <weigua@chromium.org> Date: Fri Apr 20 03:00:29 2018 Add hotword detection to media perception private API. BUG=chromium:833595 Change-Id: Ifed53adb6baef9e34c50cf09b71703d018f1617b Reviewed-on: https://chromium-review.googlesource.com/1015506 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Wei Guan <weigua@chromium.org> Cr-Commit-Position: refs/heads/master@{#552246} [modify] https://crrev.com/283e9fa129d3d4cf5c6f6ed1dab4ad15159d3fbb/chromeos/dbus/proto/media_perception.proto [modify] https://crrev.com/283e9fa129d3d4cf5c6f6ed1dab4ad15159d3fbb/extensions/browser/api/media_perception_private/conversion_utils.cc [modify] https://crrev.com/283e9fa129d3d4cf5c6f6ed1dab4ad15159d3fbb/extensions/browser/api/media_perception_private/conversion_utils_unittest.cc [modify] https://crrev.com/283e9fa129d3d4cf5c6f6ed1dab4ad15159d3fbb/extensions/common/api/media_perception_private.idl
,
Apr 20 2018
,
Apr 20 2018
,
Apr 20 2018
Appears to be a feature request post-branch?
,
Apr 20 2018
untriaged with owner -> assigned
,
Apr 20 2018
[Extensions Triage] Marking as assigned.
,
Apr 21 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 23 2018
@kbleicher: Yeah hotword detection is kind of a new feature in the media perception framework. But those changes also contain an important bug fix. So is it okay to merge both CLs back to M67?
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1d7865f1dea5217168ce4387d632090bc5f26b2 commit e1d7865f1dea5217168ce4387d632090bc5f26b2 Author: Wei Guan <weigua@chromium.org> Date: Mon Apr 23 19:37:42 2018 Add hotword detection to media perception private API. BUG=chromium:833595 Change-Id: Ifed53adb6baef9e34c50cf09b71703d018f1617b Reviewed-on: https://chromium-review.googlesource.com/1015506 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Wei Guan <weigua@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552246}(cherry picked from commit 283e9fa129d3d4cf5c6f6ed1dab4ad15159d3fbb) Reviewed-on: https://chromium-review.googlesource.com/1024570 Reviewed-by: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#230} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/e1d7865f1dea5217168ce4387d632090bc5f26b2/chromeos/dbus/proto/media_perception.proto [modify] https://crrev.com/e1d7865f1dea5217168ce4387d632090bc5f26b2/extensions/browser/api/media_perception_private/conversion_utils.cc [modify] https://crrev.com/e1d7865f1dea5217168ce4387d632090bc5f26b2/extensions/browser/api/media_perception_private/conversion_utils_unittest.cc [modify] https://crrev.com/e1d7865f1dea5217168ce4387d632090bc5f26b2/extensions/common/api/media_perception_private.idl
,
Apr 23 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/project-cfm-private/+/48fb080d237aa1aece34870a3519b40b36e8d87b commit 48fb080d237aa1aece34870a3519b40b36e8d87b Author: Wei Guan <weigua@google.com> Date: Mon Apr 23 19:40:12 2018 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Apr 19 2018