New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833576 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 20 days ago
Closed: Apr 2018
Components:
EstimatedDays: 1
NextAction: 2018-04-20
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Perf data leaking kernel file offsets

Project Member Reported by gmx@chromium.org, Apr 16 2018

Issue description

We noticed non-zero kernel file offsets in perf data reports received by CWP starting with build 10516.0.0, see b/77610802.

This was diagnosed to quipper failing to apply the right remapping to the kernel mmap after the perf uprev to 4.14.
Fix is being submitted upstream. Need to sync the quipper version used by Chrome OS on branch 67.

 
The NextAction date has arrived: 2018-04-17

Comment 2 by gmx@chromium.org, Apr 17 2018

NextAction: 2018-04-19
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6aea817eeb6ac59d7c50d292b699b8274b77284c

commit 6aea817eeb6ac59d7c50d292b699b8274b77284c
Author: Gabriel Marin <gmx@chromium.org>
Date: Tue Apr 17 22:47:33 2018

quipper: Pull the latest changes from github

Fixes kernel mmap file offset remapping.

BUG= chromium:833576 ,b:77610802
TEST=tested with emerge-amd64-generic quipper.

Change-Id: I7bd918977f2f46da384ede45870c5a667c9bc684
Reviewed-on: https://chromium-review.googlesource.com/1014493
Commit-Ready: Gabriel Marin <gmx@chromium.org>
Tested-by: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/6aea817eeb6ac59d7c50d292b699b8274b77284c/chromeos-base/quipper/Manifest
[modify] https://crrev.com/6aea817eeb6ac59d7c50d292b699b8274b77284c/chromeos-base/quipper/quipper-9999.ebuild

Comment 4 by gmx@chromium.org, Apr 18 2018

Labels: Merge-Request-67
NextAction: 2018-04-20

Comment 5 by gmx@chromium.org, Apr 18 2018

Labels: M-67
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 19 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 19 2018

Labels: merge-merged-release-R67-10575.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d47d55542ec2601a64715d780fbaca595259b1aa

commit d47d55542ec2601a64715d780fbaca595259b1aa
Author: Gabriel Marin <gmx@chromium.org>
Date: Thu Apr 19 20:15:00 2018

quipper: Pull the latest changes from github

Fixes kernel mmap file offset remapping.

BUG= chromium:833576 ,b:77610802
TEST=tested with emerge-amd64-generic quipper.

Change-Id: I7bd918977f2f46da384ede45870c5a667c9bc684
Reviewed-on: https://chromium-review.googlesource.com/1014493
Commit-Ready: Gabriel Marin <gmx@chromium.org>
Tested-by: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
(cherry picked from commit 6aea817eeb6ac59d7c50d292b699b8274b77284c)
Reviewed-on: https://chromium-review.googlesource.com/1015632
Reviewed-by: Gabriel Marin <gmx@chromium.org>
Trybot-Ready: Gabriel Marin <gmx@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>

[modify] https://crrev.com/d47d55542ec2601a64715d780fbaca595259b1aa/chromeos-base/quipper/Manifest
[modify] https://crrev.com/d47d55542ec2601a64715d780fbaca595259b1aa/chromeos-base/quipper/quipper-9999.ebuild

The NextAction date has arrived: 2018-04-20

Comment 9 by gmx@chromium.org, Apr 20 2018

Labels: Merge-Merged
Status: Fixed (was: Started)
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 23 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by gmx@chromium.org, Apr 23 2018

Labels: -Merge-Approved-67

Sign in to add a comment