New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 833569 link

Starred by 1 user
Status: Fixed
Owner:
█ bauerb@chromium.org
Not on Chrome anymore
Closed: Apr 2018
Cc:
yus...@chromium.org
ntfschr@chromium.org
pasko@chromium.org
lizeb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.customtabs.TrustedCdnPublisherUrlTest#testOfflinePage" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 16 2018 
"org.chromium.chrome.browser.customtabs.TrustedCdnPublisherUrlTest#testOfflinePage" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXAsSBUZsYWtlIlFvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuY3VzdG9tdGFicy5UcnVzdGVkQ2RuUHVibGlzaGVyVXJsVGVzdCN0ZXN0T2ZmbGluZVBhZ2UM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by ntfschr@chromium.org, Apr 17 2018

Cc: ntfschr@chromium.org
Labels: OS-Android
Owner: bauerb@chromium.org
Status: Assigned (was: Untriaged)
bauerb@ Are you the right person to investigate? I see these failures on the kitkat phone & tablet testers:

 - https://uberchromegw.corp.google.com/i/chromium.android/builders/KitKat%20Phone%20Tester%20%28rel%29
 - https://uberchromegw.corp.google.com/i/chromium.android/builders/KitKat%20Tablet%20Tester

This failed on the last 5 runs of the kitkat tablet tester, so that seems like a consistent repro.

Comment 2 by treib@chromium.org, Apr 17 2018 

Per the flakiness dashboard, this test seems to fail at least half the time:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=TrustedCdnPublisherUrlTest

Comment 3 by treib@chromium.org, Apr 17 2018

Cc: pasko@chromium.org yus...@chromium.org lizeb@chromium.org
Adding owners.
Since this is actively causing CQ pain, I'll go ahead and disable the test.

Comment 4 by bauerb@chromium.org, Apr 17 2018

Status: Started (was: Assigned)
https://crrev.com/c/1013923 might fix this.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca4498708bda22cf64f552781981aac2d99b8891

commit ca4498708bda22cf64f552781981aac2d99b8891
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Tue Apr 17 16:18:35 2018

Attempt to deflake TrustedCdnPublisherTest.testOfflinePage

Opening multiple custom tabs in quick succession can lead to flakiness,
so load a new URL in the same tab instead.

Also use the correct icon for offline pages.

Bug:  833569 
Change-Id: I87e83f65bd8883146398e5ddd9dfd7a7acd2a5c8
Reviewed-on: https://chromium-review.googlesource.com/1013923
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551352}
[modify] https://crrev.com/ca4498708bda22cf64f552781981aac2d99b8891/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/TrustedCdnPublisherUrlTest.java

Comment 6 by moh...@chromium.org, Apr 17 2018

Labels: -Sheriff-Chromium

Comment 7 by bauerb@chromium.org, Apr 18 2018

Status: Fixed (was: Started)
I think this isn't flaking anymore?
►

Sign in to add a comment