Issue 833545 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	----
Closed:	Dec 21
Cc:	agrieve@chromium.org tikuta@chromium.org █ tschumann@chromium.org erikc...@chromium.org jbudorick@chromium.org mastiz@chromium.org
Components:	Services>Sync Test>Android
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	3
Type:	Task
Sync-Triaged

Get rid of chrome_sync_shell

Project Member Reported by yfried...@chromium.org, Apr 16 2018

Issue description

I wasn't aware that we had added a chrome_public_apk_for_test: 
crrev.com/517541

Given that it allows us to "add" native code to the apk without shipping it, I think it obviates the original need for chrome sync shell. We can probably just fold fake_server into there, and simplify our builds!

Comment 1 by dtrainor@chromium.org, Apr 18 2018

Components: Test>Android Services>Sync
Labels: -Type-Bug Type-Task

Comment 2 by treib@chromium.org, Apr 23 2018

Labels: Sync-Triaged

Comment 3 by agrieve@chromium.org, May 10 2018

Status: Available (was: Untriaged)

Just filed a related bug for merging ChromePublicForTest.apk and ChromePublicTest.apk into one:  bug 841628

Comment 4 by tikuta@chromium.org, Aug 2

Cc: tikuta@chromium.org

Comment 5 by agrieve@chromium.org, Aug 28

Summary: Get rid of chrome_sync_shell and chrome_public_apk_for_test (was: Get rid of chrome_sync_shell)

Comment 6 by agrieve@chromium.org, Aug 28

Summary: Get rid of chrome_sync_shell (was: Get rid of chrome_sync_shell and chrome_public_apk_for_test)

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/dd3da2937bf902202ccfc5aea0d5c3f454c27f05

commit dd3da2937bf902202ccfc5aea0d5c3f454c27f05
Author: Andrew Grieve <agrieve@chromium.org>
Date: Wed Nov 07 19:34:40 2018

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070

commit ecac5a9e2fd689a304c899f0ee6d3f2c230b8070
Author: Andrew Grieve <agrieve@chromium.org>
Date: Thu Nov 08 01:57:01 2018

Merge most chrome test apks

chrome_public_test_apk is now the union of:
* chrome_public_apk_for_test
* chrome_public_test_apk
* chrome_sync_shell_apk
* chrome_sync_shell_test_apk

Motivation is to simplify the targets, as well as to work around
multidex restrictions.

This change disabled two tests because fixing wasn't trivial:
* FirstRunIntegrationTest.java
* FirstRunTest.java
https://crbug.com/902774 will track un-@Disable'ing them.


NOTRY=true  # linux bot flakiness
TBR=agrieve  # Trivial rename in a couple files.

Bug:  833545 ,  841628 ,  901488 
Change-Id: I9ebe035e86f1b6e5a208e36040baf038efa6cc15
Reviewed-on: https://chromium-review.googlesource.com/c/1319335
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606283}
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/BUILD.gn
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/WATCHLISTS
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/base/test/android/javatests/src/org/chromium/base/test/BaseChromiumAndroidJUnitRunner.java
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/build/android/gradle/generate_gradle.py
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/build/android/main_dex_classes.flags
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/BUILD.gn
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/java_sources.gni
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/AndroidManifest.xml
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/AndroidManifest_monochrome.xml
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/DEPS
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/browserservices/OriginVerifierTest.java
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityTest.java
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/AutofillTest.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/FakeServerHelper.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTestRule.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/UkmTest.java
[rename] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseTypeDialogFragmentTest.java
[delete] https://crrev.com/939f1a0e0c1bf8f2453b8f705471463f1455cab0/chrome/android/sync_shell/DEPS
[delete] https://crrev.com/939f1a0e0c1bf8f2453b8f705471463f1455cab0/chrome/android/sync_shell/README
[delete] https://crrev.com/939f1a0e0c1bf8f2453b8f705471463f1455cab0/chrome/android/sync_shell/javatests/AndroidManifest.xml
[delete] https://crrev.com/939f1a0e0c1bf8f2453b8f705471463f1455cab0/chrome/android/sync_shell/javatests/DEPS
[delete] https://crrev.com/939f1a0e0c1bf8f2453b8f705471463f1455cab0/chrome/browser/android/chrome_sync_shell_entry_point.cc
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/browser/metrics/ukm_browsertest.cc
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/chrome/test/android/test_trusted_web_activity/src/org/chromium/chrome/browser/browserservices/TestTrustedWebActivityService.java
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/components/sync/BUILD.gn
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/content/shell/BUILD.gn
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/docs/android_test_instructions.md
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/testing/buildbot/chromium.android.json
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/ecac5a9e2fd689a304c899f0ee6d3f2c230b8070/testing/buildbot/test_suites.pyl

Comment 9 by agrieve@chromium.org, Dec 21

Status: Fixed (was: Available)

►

Issue 833545 link

Issue metadata

Get rid of chrome_sync_shell

Issue description

Comment 1 by dtrainor@chromium.org, Apr 18 2018

Comment 1 Deleted

Comment 2 by treib@chromium.org, Apr 23 2018

Comment 2 Deleted

Comment 3 by agrieve@chromium.org, May 10 2018

Comment 3 Deleted

Comment 4 by tikuta@chromium.org, Aug 2

Comment 4 Deleted

Comment 5 by agrieve@chromium.org, Aug 28

Comment 5 Deleted

Comment 6 by agrieve@chromium.org, Aug 28

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Nov 7

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Nov 8

Comment 8 Deleted

Comment 9 by agrieve@chromium.org, Dec 21

Comment 9 Deleted

Sign in to add a comment