New issue
Advanced search Search tips

Issue 833532 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PaymentHandler: If openWindow() is not triggered by user activation, then should throw NotAllowedError.

Project Member Reported by jinho.b...@samsung.com, Apr 16 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aa2044c320e5aa09c28d8fafc69020800fc5914

commit 4aa2044c320e5aa09c28d8fafc69020800fc5914
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Apr 25 18:57:27 2018

PaymentHandler: Should use NotAllowedError instead of InvalidAccessError

When openWindow() is not triggered by user activation, currently throws
InvalidAccessError. But it's already deprecated in spec level. Instead
we should throw NotAllowedError.

Related spec change:
  https://github.com/w3c/payment-handler/pull/291

Bug:  833532 
Change-Id: Icc21301abcafa0ecd00d6232d73a273ca6e4dd9b
Reviewed-on: https://chromium-review.googlesource.com/1013659
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553685}
[modify] https://crrev.com/4aa2044c320e5aa09c28d8fafc69020800fc5914/third_party/blink/renderer/modules/payments/payment_request_event.cc

Status: Fixed (was: Started)

Sign in to add a comment