New issue
Advanced search Search tips

Issue 833520 link

Starred by 2 users
Status: Fixed
Owner:
aee@chromium.org
Closed: May 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
hcarmona@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD Extensions] Focus lost when closing "pack extension" dialog.

Project Member Reported by dpa...@chromium.org, Apr 16 2018 
Repro steps (see screencast):

1) Turn on Devolper mode
2) Tab to "pack extension" button.
3) Hit 'enter' to open the "pack extension" dialog.
4) Hit 'esc' to close the dialog.

Expected: Focus goes back to the "pack extension" button.
Actual: Focus is lost (goes to omnibox).

Comment 1 by dpa...@chromium.org, Apr 16 2018

Cc: hcarmona@chromium.org

Comment 2 by dpa...@chromium.org, Apr 16 2018

pack_extension_focus_lost.mp4
365 KB View Download

Comment 3 by hcarmona@chromium.org, Apr 16 2018

Cc: nyerramilli@chromium.org rbasuvula@chromium.org
 Issue 822153  has been merged into this issue.

Comment 4 by aee@chromium.org, May 21 2018

Owner: aee@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/091e1506a5d7b50a67f40d58b98aa348704c3ba6

commit 091e1506a5d7b50a67f40d58b98aa348704c3ba6
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu May 31 21:38:13 2018

Extensions WebUI: focus on pack extensions button when dialog closes

Bug:  833520 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice16e7d009356dd0af9d19a60e4f38de985d99dc
Reviewed-on: https://chromium-review.googlesource.com/1068148
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563382}
[modify] https://crrev.com/091e1506a5d7b50a67f40d58b98aa348704c3ba6/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/091e1506a5d7b50a67f40d58b98aa348704c3ba6/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/091e1506a5d7b50a67f40d58b98aa348704c3ba6/chrome/browser/resources/md_extensions/pack_dialog.js
[modify] https://crrev.com/091e1506a5d7b50a67f40d58b98aa348704c3ba6/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/091e1506a5d7b50a67f40d58b98aa348704c3ba6/chrome/browser/resources/md_extensions/toolbar.js
[modify] https://crrev.com/091e1506a5d7b50a67f40d58b98aa348704c3ba6/chrome/test/data/webui/extensions/extension_pack_dialog_test.js
[modify] https://crrev.com/091e1506a5d7b50a67f40d58b98aa348704c3ba6/chrome/test/data/webui/extensions/extension_toolbar_test.js

Comment 6 by aee@chromium.org, May 31 2018

Status: Fixed (was: Started)
►

Sign in to add a comment