New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833486 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Offline page shared from A -> B -> A through ShareIt are treated as untrusted.

Project Member Reported by freedjm@chromium.org, Apr 16 2018

Issue description

What steps will reproduce the problem?
(1) Save a page for offline in Chrome on device A
(2) Use ShareIt to share the page from device A to device B
(3) Use ShareIt to share the page from device B to device A
(4) Open the shared page on device A

What is the expected result?
The page should be treated as trusted by chrome.

What happens instead?
The page is treated as untrusted.


 
Labels: -Pri-3 Pri-2
Owner: jianli@chromium.org
Status: Assigned (was: Untriaged)
Drive by, given the status of the bug:
This works as intended, as the page has left the custody of the device/chrome.

Comment 3 by jianli@chromium.org, Apr 16 2018

Cc: petewil@chromium.org
Owner: freedjm@chromium.org
For comment #2, we do support this scenario since we can verify the file via digest.

I can't repro this with 6.0.1. Can anyone repro this?
I could not repo this with 8.1.0 (device A) and dogfood of P (device B).

IIRC, during the bug bash I shared this with petewil@ and his device was running KitKat. 
To be specific, the A device was dogfood P, and the B device was KitKat (4.4.1)
I tried this with device A as Android Nougat and device B as Oreo, it did not repro.

I tried using the original device B, but it is broken now, and I was unable to get ShareIt to send the file back.  I tried this with another KitKat phone, but it was unable to use ShareIt with the Nougat phone.
I found a way to repro this after all, going from  Nougat to KitKat - the missing step is to first send a file from KitKat to Nougat to establish the WiFi connection, then do the rest of the repro steps.
Owner: petewil@chromium.org
Status: Started (was: Assigned)
Looks like the problem is that there is a "!" in the file: url, and MimeTypeMap.getFileExtensionFromUrl is considering it a non-valid URL, and refusing to return the "mhtml" at the end, so this is not looking like a MHTML file. 
Labels: Merge-Request-67
https://chromium-review.googlesource.com/c/chromium/src/+/1033482 landed to fix this.

We would like to merge the fix, which is basically just checking offline pages file extension differently.

The change is to look for the file extension as everything after the last dot instead of excluding all filenames with characters that might be legal for files but are not legal for urls, and then looking for the last dot.


Project Member

Comment 11 by sheriffbot@chromium.org, May 2 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
has the fix been verified in canary?
Thanks for getting back to me!

The fix was not in this morning's canary.  It went in about 5pm yesterday, not sure when the canary syncs.
I also didn't see a fix from Tuesday in this morning's canary, so I wonder when Canary synced last.

I'll try again with tomorrow's canary.
Verified in today's canary.
Labels: offlie-pages-p2p
Status: Fixed (was: Started)
Labels: -Hotlist-Merge-Review -Merge-Review-67 Merge-Approved-67
I hope this merge is safe for M67.
Labels: Merge-Merged
Project Member

Comment 18 by sheriffbot@chromium.org, May 14 2018

Cc: cma...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-67

Sign in to add a comment