In flake_try_job.ScheduleFlakeTryJob, parameters.dimensions should not be None |
||
Issue descriptionPage URL: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVysQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ7Y2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKDEpLzc5MDkwL2NvbnRlbnRfYnJvd3NlcnRlc3RzL1ZHOTFZMmhCWTNScGIyNUNjbTkzYzJWeVZHVnpkQzVRWVc1WVdVRjBXVUZ5WldGTllXbHVWR2h5WldGa1NtRnVhM2s9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Description: Error log is https://pantheon.corp.google.com/errors/CN_KuYilo9zpZg?time=P30D&project=findit-for-me Debug capture is: https://pantheon.corp.google.com/debug?repo=appengine:%3Fservice%3Dwaterfall-backend%26version%3D14943-ca594cf&fp=%2Fservices%2Fflake_failure%2Fflake_try_job.py&fl=312&lpopen=true&lpeid=5ad4d2320009d130fa21667c:1&lpet=1523896882030&lpee=false&dlv=4&project=findit-for-me&app=GAE:waterfall-backend@14943-ca594cf&bp=569f9e45e758d-9135-32da8
,
Apr 16 2018
,
Apr 24 2018
I don't understand either. But the call stack in the error showed that parameters.dimensions is None. AttributeError: 'NoneType' object has no attribute 'ToSerializable' at ScheduleFlakeTryJob (/base/data/home/apps/s~findit-for-me/waterfall-backend:14943-ca594cf.408981509714524873/services/flake_failure/flake_try_job.py:312) at RunImpl (/base/data/home/apps/s~findit-for-me/waterfall-backend:14943-ca594cf.408981509714524873/pipelines/flake_failure/run_flake_try_job_pipeline.py:81) at run (/base/data/home/apps/s~findit-for-me/waterfall-backend:14943-ca594cf.408981509714524873/gae_libs/pipelines.py:420) at _run_internal (/base/data/home/apps/s~findit-for-me/waterfall-backend:14943-ca594cf.408981509714524873/infra_api_clients/../third_party/pipeline/pipeline.py:1113) at evaluate (/base/data/home/apps/s~findit-for-me/waterfall-backend:14943-ca594cf.408981509714524873/infra_api_clients/../third_party/pipeline/pipeline.py:2158)
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/8dfb290cb675e6e4dd53c12f484e144939e9c893 commit 8dfb290cb675e6e4dd53c12f484e144939e9c893 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Wed Apr 25 20:42:38 2018 [Findit] Flake Analyzer - Fixing nonetype for try job dimensions waterfall_config may return None as the try bot dimensions. When bubbling this up to the caller code, ListOfBasestring.FromSerializable(None) will also be none. Thus when passing this to services/try_job.py.TriggerTryJob, which expects a list, None is called with ToSerializable() causing the exception. Bug: 833468 Change-Id: Ia13c36a45f2cdcd7181d5714ce9d139194d40e5b Reviewed-on: https://chromium-review.googlesource.com/1026457 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/8dfb290cb675e6e4dd53c12f484e144939e9c893/appengine/findit/services/flake_failure/flake_try_job.py
,
Apr 30 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by st...@chromium.org
, Apr 16 2018