2D UI - Dialogs are larger and extend to the right making them feel off centered. |
||||||||||
Issue descriptionChrome Version: 67.0.3396.3 Canary build OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (1) Open https://www.google.com (2) Enter VR Browsing (3) Click the Info icon on the Omnibox. What is the expected result? The Info dialog should be displayed appropriately on the screen. What happens instead? The Info dialog is much larger and extends to the right making it feel like it is off centered. This is happening for other dialogs also. permission dialogs. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Apr 17 2018
Found the scenario. It requires at minimum signing out of Chrome, possibly also clearing the data and cache for Chrome. (1) Sign out of Chrome (2) Clear the Chrome data and cache (3) Open https://www.google.com (4) Enter VR Browsing (5) Click the Info icon on the Omnibox. Current repro was on Pixel 2 XL
,
Apr 18 2018
FWIW, I can't repro on Pixel 1 non-XL.
,
Apr 18 2018
It looks to be related to 'floating' flag in the hosted_ui model. I think we don't reset it after showing a floating dialog.
,
Apr 18 2018
,
Apr 18 2018
Assigning to Amir since he seems to have a beat on it
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb0c86e6087c4522d046d042898494e5b92fab86 commit fb0c86e6087c4522d046d042898494e5b92fab86 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Mon Apr 23 22:44:55 2018 Reset Floating flag when dialog is not floating Floating flag should be set to false when a Dialog is not anchored to the main content. Bug: 833466 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Idad148d25bc1d51e6ba2b764426d2b8dc6b380a4 Reviewed-on: https://chromium-review.googlesource.com/1024231 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#552868} [modify] https://crrev.com/fb0c86e6087c4522d046d042898494e5b92fab86/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDialog.java [modify] https://crrev.com/fb0c86e6087c4522d046d042898494e5b92fab86/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDialogManager.java [modify] https://crrev.com/fb0c86e6087c4522d046d042898494e5b92fab86/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrPopupWindow.java [modify] https://crrev.com/fb0c86e6087c4522d046d042898494e5b92fab86/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/fb0c86e6087c4522d046d042898494e5b92fab86/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/fb0c86e6087c4522d046d042898494e5b92fab86/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/fb0c86e6087c4522d046d042898494e5b92fab86/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/fb0c86e6087c4522d046d042898494e5b92fab86/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/fb0c86e6087c4522d046d042898494e5b92fab86/chrome/browser/vr/ui.cc [modify] https://crrev.com/fb0c86e6087c4522d046d042898494e5b92fab86/chrome/browser/vr/ui.h
,
Apr 24 2018
,
Apr 25 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20d106889b65082a4a1ad9f694414cc426821e4c commit 20d106889b65082a4a1ad9f694414cc426821e4c Author: Amirhossein Simjour <asimjour@chromium.org> Date: Wed Apr 25 15:25:10 2018 Reset Floating flag when dialog is not floating Floating flag should be set to false when a Dialog is not anchored to the main content. Bug: 833466 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Idad148d25bc1d51e6ba2b764426d2b8dc6b380a4 Reviewed-on: https://chromium-review.googlesource.com/1024231 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552868}(cherry picked from commit fb0c86e6087c4522d046d042898494e5b92fab86) Reviewed-on: https://chromium-review.googlesource.com/1028330 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#290} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/20d106889b65082a4a1ad9f694414cc426821e4c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDialog.java [modify] https://crrev.com/20d106889b65082a4a1ad9f694414cc426821e4c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDialogManager.java [modify] https://crrev.com/20d106889b65082a4a1ad9f694414cc426821e4c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrPopupWindow.java [modify] https://crrev.com/20d106889b65082a4a1ad9f694414cc426821e4c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/20d106889b65082a4a1ad9f694414cc426821e4c/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/20d106889b65082a4a1ad9f694414cc426821e4c/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/20d106889b65082a4a1ad9f694414cc426821e4c/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/20d106889b65082a4a1ad9f694414cc426821e4c/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/20d106889b65082a4a1ad9f694414cc426821e4c/chrome/browser/vr/ui.cc [modify] https://crrev.com/20d106889b65082a4a1ad9f694414cc426821e4c/chrome/browser/vr/ui.h
,
Apr 25 2018
,
May 8 2018
Fix verified on build 67.0.3396.29 beta. Looks good. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dougman@chromium.org
, Apr 16 2018Owner: dougman@chromium.org
Status: WontFix (was: Untriaged)