New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833456 link

Starred by 4 users

Issue metadata

Status: Fixed
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Sign in to add a comment

Chrome crashes when running in mash on device

Project Member Reported by, Apr 16 2018

Issue description

Chrome crashes when running in mash on device.
Looks like caused by

Basically, the following line returns null on mash:
and exo::Pointer code crashes when trying to add an observer.


desktopui_MashLogin crashes:

Build: gandof-release/R68-10588.0.0.

Unhandled BrowserGoneException: Connection is already closed..
build artifacts:
results log:
Status: Assigned (was: Untriaged)
Can the mash checks be added back to that code? It looks like there were some checks that were removed.

It would be good to get the lab green so we can watch for new regressions.

 Issue 796284  has been merged into this issue.
xiyuan, are you sure that's the right CL? The CL landed in January.

Comment 4 by, Apr 16 2018

Re #3: Yes, pretty sure that is the root cause.

Think it is revealed now because sky's CL:

That turns on wayland server on mash (i.e. --ash-enable-wayland-server is gone and --enable-wayland-server would turn on wayland server for mash).
Project Member

Comment 5 by, Apr 16 2018

Labels: merge-merged-release-R67-10575.B
The following revision refers to this bug:

commit 1c3c85a039e8345ed05e54078bba49f2a071f336
Author: James Cook <>
Date: Mon Apr 16 23:27:21 2018

autotest: Disable desktopui_MashLogin on R67 branch

The test fails due to a known issue that has been fixed on
tip-of-trunk, so just disable the test on the branch to
reduce email spam from the lab.

BUG= chromium:833456 

Change-Id: I0984b0e44ed6be31cf4ef27f78be9c1a6a6f02c3
Reviewed-by: James Cook <>
Tested-by: James Cook <>


Comment 6 by, Apr 17 2018

What's the right way to access cursor client/manager in mash?
Components: Internals>Services>Ash
+sky, I don't think we have a good cursor client/manager solution for mash. erg@ worked on cursors before he left. I think it was an intentional design decision that ash::Shell::cursor_manager() was null, because there was no "global" cursor manager. I suspect cursor management is per-top-level-window, but I'm not sure what the intended replacement was.

Maybe just skip the code for now and leave a TODO for mash?

Comment 8 by, Apr 17 2018

I have a question:  the CL in comment 5 said "The test fails due to a known issue that has been fixed on tip-of-trunk"

Which CL has fixed that null pointer access issue? I checked history of it seems the latest commit is still 3 days aog:

Comment 9 by, Apr 17 2018

Ok, let me do that or now, since other places does seem to do the same.
Status: Started (was: Assigned)
Project Member

Comment 11 by, Apr 17 2018

The following revision refers to this bug:

commit bf470281c992fae0012930e6e38121d6884a65cd
Author: Mitsuru Oshima <>
Date: Tue Apr 17 09:00:57 2018

Skip cursor client operation in mash.

BUG= 833456 

Change-Id: I9d01f94670a406ea7b30b4c232775dc76ad4a48c
Commit-Queue: Mitsuru Oshima <>
Reviewed-by: Scott Violet <>
Reviewed-by: David Reveman <>
Cr-Commit-Position: refs/heads/master@{#551282}

@lepton - The commit comment in comment 5 was wrong, sorry. I copy/pasted it from the last time I disabled this test on a branch. It looks like oshima just fixed the crash.
Status: Fixed (was: Started)
 Issue 834321  has been merged into this issue.

Sign in to add a comment