Page URL: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKZAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzY4NjIvaW50ZXJhY3RpdmVfdWlfdGVzdHMvUkhsdVlXMXBZMFp2Y20xSmJuUmxjbUZqZEdsMlpWUmxjM1F1UkhsdVlXMXBZME5vWVc1bmFXNW5SbTl5YlVacGJHeGZVMlZzWldOMFZYQmtZWFJsWkE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Description: After 24H, RunFlakeSwarmingTaskPipeline should timeout.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/6269083b0d856515e6f3d90f69b7debac58cf20b commit 6269083b0d856515e6f3d90f69b7debac58cf20b Author: Jeffrey Li <lijeffrey@chromium.org> Date: Fri Apr 20 18:57:07 2018 [Findit] Flake Analyzer - Fixing key errors in handling swarming task pipeline timeout When the pipeline for a swarming task times out waiting for the task to trigger or complete, not all information is available. The calling code expects task_id, created_ts, etc. to be populated, but they may simply not be available yet depending on the timeout leading to key errors. Because of the key errors, the callback task to raise a pipeline abort does not have the chance to abort the asynchronous pipeline causing the pipeline to appear as though it's still running after the timeout. Bug: 833455 Change-Id: I0467575729947b3ee86ac4266b55f4ac55a1818f Reviewed-on: https://chromium-review.googlesource.com/1020463 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> [modify] https://crrev.com/6269083b0d856515e6f3d90f69b7debac58cf20b/appengine/findit/pipelines/test_failure/run_test_swarming_task_pipeline.py [modify] https://crrev.com/6269083b0d856515e6f3d90f69b7debac58cf20b/appengine/findit/pipelines/flake_failure/run_flake_swarming_task_pipeline.py [modify] https://crrev.com/6269083b0d856515e6f3d90f69b7debac58cf20b/appengine/findit/pipelines/compile_failure/run_compile_try_job_pipeline.py [modify] https://crrev.com/6269083b0d856515e6f3d90f69b7debac58cf20b/appengine/findit/services/flake_failure/test/flake_swarming_test.py [modify] https://crrev.com/6269083b0d856515e6f3d90f69b7debac58cf20b/appengine/findit/gae_libs/pipelines.py [modify] https://crrev.com/6269083b0d856515e6f3d90f69b7debac58cf20b/appengine/findit/services/flake_failure/flake_swarming.py
Comment 1 by lijeffrey@chromium.org
, Apr 19 2018Status: Started (was: Available)