[VR Browsing Sounds] Remove sounds for permission indicators |
||||||
Issue descriptionChrome Version: 67.0.3396.3 VRCore: 1.14.190701955 OS: Android N Device: Pixel What steps will reproduce the problem? (1) Open Chrome, enter VR browsing. (2) Go to http://permission.site/ (3) Click on the microphone button, confirm request for access to microphone if prompted. (4) Hover over and click on the microphone icon (permission indicator) What is the expected result? No sounds should play. What happens instead? A hover over and click sound is played.
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31b364c7df59f3e16205b3ab4cbf9fd99d9259fe commit 31b364c7df59f3e16205b3ab4cbf9fd99d9259fe Author: Christopher Grant <cjgrant@chromium.org> Date: Fri Apr 20 00:41:52 2018 VR: Remove sounds from permission indicator buttons BUG= 833439 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I483b430931a7719d8db91ac1b45b080de9d4480b Reviewed-on: https://chromium-review.googlesource.com/1020151 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#552219} [modify] https://crrev.com/31b364c7df59f3e16205b3ab4cbf9fd99d9259fe/chrome/browser/vr/ui_scene_creator.cc
,
Apr 23 2018
,
Apr 23 2018
Please confirm the fix works in canary
,
Apr 23 2018
Verified in canary 68.0.3404 (initially landed in 68.0.3401.0).
,
Apr 24 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d34dfee47b207824d4f6de3536acdc8574de8a9c commit d34dfee47b207824d4f6de3536acdc8574de8a9c Author: Christopher Grant <cjgrant@chromium.org> Date: Tue Apr 24 14:02:27 2018 VR: Remove sounds from permission indicator buttons BUG= 833439 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I483b430931a7719d8db91ac1b45b080de9d4480b Reviewed-on: https://chromium-review.googlesource.com/1020151 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552219}(cherry picked from commit 31b364c7df59f3e16205b3ab4cbf9fd99d9259fe) Reviewed-on: https://chromium-review.googlesource.com/1025080 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#253} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/d34dfee47b207824d4f6de3536acdc8574de8a9c/chrome/browser/vr/ui_scene_creator.cc
,
Apr 24 2018
,
May 8 2018
Fix verified on build 67.0.3396.29 beta. Looks good. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by cjgrant@chromium.org
, Apr 20 2018Owner: cjgrant@chromium.org
Status: Started (was: Untriaged)