New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 833430 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 417518



Sign in to add a comment

ResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses fails with --site-per-process on Win10

Project Member Reported by lukasza@chromium.org, Apr 16 2018

Issue description

D:\src\chromium\src>out\rel\browser_tests --gtest_filter=ResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses --site-per-process
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = ResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ResourceCoordinatorRenderProcessProbeBrowserTest, where TypeParam =
[ RUN      ] ResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses
[3828:8216:0416/081534.222:ERROR:install_util.cc(589)] Unable to create registry key HKLM\SOFTWARE\Policies\Chromium for reading result=2
[3828:7684:0416/081534.305:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[3828:8216:0416/081534.317:WARNING:chrome_browser_main_win.cc(630)] Command line too long for RegisterApplicationRestart:  --gtest_also_run_disabled_tests --gtest_filter=ResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses --single_process --site-per-process --test-launcher-output="D:\src\tmp\scoped_dir13584_24795\results13584_26813\test_results.xml" --user-data-dir="D:\src\tmp\scoped_dir13584_24795\d13584_10225" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
../../chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc(97): error: Expected equality of these values:
  initial_size + 1u
    Which is: 3
  probe.render_process_info_map_for_testing().size()
    Which is: 2
../../chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc(109): error: Expected equality of these values:
  initial_size
    Which is: 2
  probe.render_process_info_map_for_testing().size()
    Which is: 1
[3828:8216:0416/081535.906:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[3828:8216:0416/081535.909:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] ResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses, where TypeParam =  and GetParam() =  (1709 ms)


The failure seems to happen only on Windows 10 (after looking at tryjobs results in https://crrev.com/c/981019)
 
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)
This test had to be modified to account for the spare RenderProcessHost on Linux - I am guessing that on Win10 the test doesn't sufficiently synchronize its execution with the timing of spare creation.  In other words - this seems like a relatively benign test issue.
Cc: zh...@chromium.org
Owner: lukasza@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd

commit fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Sat Apr 21 14:55:20 2018

Make --site-per-process the default on ToT via fieldtrial_testing_config

Note that features::kSitePerProcess is a //chrome-layer feature.
Therefore, after this CL:
- site-per-process is turned-on by default in //chrome layer and above
  (i.e. in code that uses ChromeContentBrowserClient).
- site-per-process stays off by default in //content layer

Also note that fieldtrial_testing_config.json only affects how default
Chromium tests are run, but doesn't affect the default behavior of
Chrome builds shipped to end-users - these will continue to have
site-per-process off by default (and controlled via field trials).

In addition to making site-per-process the default, the CL makes the
following supplementary changes:
- site_per_process_browser_tests test step is removed and replaced
  by not_site_per_process_browser_tests (similarily for a few other
  //chrome-layer test suites where I've verified that
  content::AreAllSitesIsolatedForTesting returns true after this CL).
- A few last-minute changes to disable tests that fail with
  --site-per-process - these changes are limited to site-per-process
  and/or specific platforms.

Bug:  824966 , 831078,  833423 , 833429, 833430
Change-Id: Ie87e48658864203d33d1ae647fb2d98a7c488765
Tbr: zhenw@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/981019
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552589}
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/extensions/extension_messages_apitest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/policy/site_isolation_policy_browsertest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/content/public/browser/site_isolation_policy.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment