New issue
Advanced search Search tips

Issue 833429 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 417518



Sign in to add a comment

MessagingApiTest.MessagingInterstitial times out with --site-per-process

Project Member Reported by lukasza@chromium.org, Apr 16 2018

Issue description

D:\src\chromium\src>out\rel\browser_tests --gtest_filter=NativeBindings/MessagingApiTest.MessagingInterstitial/0 --site-per-process
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = NativeBindings/MessagingApiTest.MessagingInterstitial/0
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from NativeBindings/MessagingApiTest
[ RUN      ] NativeBindings/MessagingApiTest.MessagingInterstitial/0
[8628:8816:0416/080931.930:ERROR:install_util.cc(589)] Unable to create registry key HKLM\SOFTWARE\Policies\Chromium for reading result=2
[8628:10816:0416/080932.018:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[8628:8816:0416/080932.030:WARNING:chrome_browser_main_win.cc(630)] Command line too long for RegisterApplicationRestart:  --gtest_also_run_disabled_tests --gtest_filter=NativeBindings/MessagingApiTest.MessagingInterstitial/0 --single_process --site-per-process --test-launcher-output="D:\src\tmp\scoped_dir14220_6229\results14220_16959\test_results.xml" --user-data-dir="D:\src\tmp\scoped_dir14220_6229\d14220_2214" --disable-offline-auto-reload --allow-legacy-extension-manifests --disable-renderer-backgrounding --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=NativeCrxBindings,TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[8628:8816:0416/080933.852:INFO:CONSOLE(0)] "Unchecked runtime.lastError: Could not establish connection. Receiving end does not exist.", source: data:text/html;charset=utf-8,%3C!doctype%20html%3E%0A%3Chtml%20dir=%22ltr%22%20lang=%22en%22%3
...
[1/1] NativeBindings/MessagingApiTest.MessagingInterstitial/0 (TIMED OUT)


The timeout seems to happen only on Windows 10 (after looking at tryjobs results in https://crrev.com/c/981019)
 
Summary: MessagingApiTest.MessagingInterstitial times out with --site-per-process (was: NativeBindings/MessagingApiTest.MessagingInterstitial/0 times out with --site-per-process)
Similar issue happens in JavaScriptBindings/MessagingApiTest.MessagingInterstitial/0.

I also note that the timeout doesn't consistently repro on my local machine - it may be necessary to use --gtest_repeat=10 to get a repro.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd

commit fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Sat Apr 21 14:55:20 2018

Make --site-per-process the default on ToT via fieldtrial_testing_config

Note that features::kSitePerProcess is a //chrome-layer feature.
Therefore, after this CL:
- site-per-process is turned-on by default in //chrome layer and above
  (i.e. in code that uses ChromeContentBrowserClient).
- site-per-process stays off by default in //content layer

Also note that fieldtrial_testing_config.json only affects how default
Chromium tests are run, but doesn't affect the default behavior of
Chrome builds shipped to end-users - these will continue to have
site-per-process off by default (and controlled via field trials).

In addition to making site-per-process the default, the CL makes the
following supplementary changes:
- site_per_process_browser_tests test step is removed and replaced
  by not_site_per_process_browser_tests (similarily for a few other
  //chrome-layer test suites where I've verified that
  content::AreAllSitesIsolatedForTesting returns true after this CL).
- A few last-minute changes to disable tests that fail with
  --site-per-process - these changes are limited to site-per-process
  and/or specific platforms.

Bug:  824966 , 831078,  833423 , 833429, 833430
Change-Id: Ie87e48658864203d33d1ae647fb2d98a7c488765
Tbr: zhenw@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/981019
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552589}
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/extensions/extension_messages_apitest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/policy/site_isolation_policy_browsertest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/content/public/browser/site_isolation_policy.cc
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/fb1ccf02ee8ca79e1404abfd3a3a7d540b7d2dbd/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/013caa6e61d5bc01963aa9bc6001268bd42e82ed

commit 013caa6e61d5bc01963aa9bc6001268bd42e82ed
Author: Xida Chen <xidachen@chromium.org>
Date: Mon Apr 23 14:08:28 2018

Disable MessagingApiTest.MessagingInterstitial on Mac

It has been timing out for a while on mac
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=MessagingApiTest.MessagingInterstitial

TBR=clamy@chromium.org
NOTRY=true

Bug: 833429
Change-Id: I886c2945305fff2dfcf9849a9690d93ddc8d60ed
Reviewed-on: https://chromium-review.googlesource.com/1024052
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552686}
[modify] https://crrev.com/013caa6e61d5bc01963aa9bc6001268bd42e82ed/chrome/browser/extensions/extension_messages_apitest.cc

Sign in to add a comment